search

OliveStudio / olivemenus

A powerful menus plugin for Craft CMS built for the need of simplicity and flexibility
MIT License
40 stars 22 forks source link

header.uniqueId is not a function #5

Closed csoutham closed 7 years ago

csoutham commented 7 years ago

Hi, this is a great plugin. Can't believe I've only just found it. However, in the latest version of Craft (v2.6.2958) there's a jQuery UI error from accordion which causes it not to work.

As far as I can make out there's no conflict with another plugin.

Uncaught TypeError: header.uniqueId is not a function

283 headerId = header.uniqueId().attr( "id" ),

/admin/resources/olivemenus/js/jquery-ui.js?d=1475451678

Any ideas? Would love to keep using it!

neagucatalinmihai commented 7 years ago

Hi

We will investigate and let you know

Thanks !

From: Chris Southam notifications@github.com Sent: Saturday, January 7, 2017 10:23 AM To: OliveStudio/olivemenus Cc: Subscribed Subject: [OliveStudio/olivemenus] header.uniqueId is not a function (#5)

Hi, this is a great plugin. Can't believe I've only just found it. However, in the latest version of Craft (v2.6.2958) there's a jQuery UI error from accordion which causes it not to work.

As far as I can make out there's no conflict with another plugin.

Uncaught TypeError: header.uniqueId is not a function

283 headerId = header.uniqueId().attr( "id" ),

/admin/resources/olivemenus/js/jquery-ui.js?d=1475451678

Any ideas? Would love to keep using it!

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/OliveStudio/olivemenus/issues/5, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEPClEllDuTyspvppKFcDifTovu8DvKwks5rP0togaJpZM4LdXfh.

csoutham commented 7 years ago

I've fixed with it a new download of jQuery UI (Sortable, Accordion, Tabs & Mouse) from v1.12.1 - replacing the existing 1.11.4 but haven't checked compatibility moving backwards through Craft versions.

alinistrate commented 7 years ago

Hello,

Thanks for letting us know about this error. We are currently working to fix this.

We will push an updated version next days.

Thanks

csoutham commented 7 years ago

I replaced jquery-ui.js with this later version (renamed to just jquery-ui.js) in resources/js/ jquery-ui.js.txt

alinistrate commented 7 years ago

Hello,

This issue is now fixed.

Thank you

alinistrate commented 7 years ago

Hello,

This issue is fixed now. Please get the latest version from github.

Thanks, Alin

[Olive Studio]http://www.olivestudio.net/

Istrate Alin Dumitru OLIVE STUDIO Romania, Sibiu, 5 Gen. Magheru Str. Skype: alin.istrate2

From: Chris Southam [mailto:notifications@github.com] Sent: Wednesday, January 11, 2017 1:47 PM To: OliveStudio/olivemenus olivemenus@noreply.github.com Cc: Alin Istrate alin.istrate@olivestudio.net; Comment comment@noreply.github.com Subject: Re: [OliveStudio/olivemenus] header.uniqueId is not a function (#5)

I replaced jquery-ui.js with this later version (renamed to just jquery-ui.js) in resources/js/ jquery-ui.js.txthttps://github.com/OliveStudio/olivemenus/files/698700/jquery-ui.js.txt

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/OliveStudio/olivemenus/issues/5#issuecomment-271848835, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEzk0RkmG-VeCdl5PnQioLLQDwApgmMuks5rRME4gaJpZM4LdXfh.