Oliver-Loeffler / FXFileChooser

Custom JavaFX file chooser which allows quick manual filtering, which allows to add Path predicates as filter and which is testable using TestFX.
Apache License 2.0
44 stars 8 forks source link

Java fx file chooser adapter #29

Closed Oliver-Loeffler closed 5 years ago

Oliver-Loeffler commented 5 years ago

Achievements

Sorting by lastModified date works fine now. See #28 UpdateService and FindFilesTask are now shutdown properly. See #27 JavaFX FileChooser and DirectoryChooser now work in an acceptable way on Windows #26

Sill open

SwingFileChooser (for large directories) is not yet able to provide a handle so that the JavaFX DirectoryChooser can be used with proper modality.

Issues:

On OSX modality does not work as expected.

codecov[bot] commented 5 years ago

Codecov Report

Merging #29 into master will decrease coverage by 1.94%. The diff coverage is 18.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   18.45%   16.51%   -1.95%     
==========================================
  Files          20       27       +7     
  Lines         596      757     +161     
  Branches       35       44       +9     
==========================================
+ Hits          110      125      +15     
- Misses        475      621     +146     
  Partials       11       11
Impacted Files Coverage Δ
...raumzeitfalle/fx/filechooser/SwingFileChooser.java 0% <ø> (ø) :arrow_up:
...tfalle/fx/filechooser/SwingDialogReturnValues.java 0% <0%> (ø)
...eitfalle/fx/filechooser/FileChooserController.java 0% <0%> (ø) :arrow_up:
...zeitfalle/fx/filechooser/SwingNodeFileChooser.java 0% <0%> (ø)
.../main/java/net/raumzeitfalle/fx/SwingNodeDemo.java 0% <0%> (ø)
...mzeitfalle/fx/filechooser/StandardFileChooser.java 0% <0%> (ø)
...et/raumzeitfalle/fx/filechooser/FilesListCell.java 0% <0%> (ø) :arrow_up:
...tfalle/fx/filechooser/FileSystemDialogAdapter.java 0% <0%> (ø)
...falle/fx/filechooser/StandardDirectoryChooser.java 0% <0%> (ø)
...aumzeitfalle/fx/filechooser/FileUpdateService.java 0% <0%> (ø) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37493bb...0530422. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #29 into master will decrease coverage by 1.94%. The diff coverage is 18.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   18.45%   16.51%   -1.95%     
==========================================
  Files          20       27       +7     
  Lines         596      757     +161     
  Branches       35       44       +9     
==========================================
+ Hits          110      125      +15     
- Misses        475      621     +146     
  Partials       11       11
Impacted Files Coverage Δ
...raumzeitfalle/fx/filechooser/SwingFileChooser.java 0% <ø> (ø) :arrow_up:
...tfalle/fx/filechooser/SwingDialogReturnValues.java 0% <0%> (ø)
...eitfalle/fx/filechooser/FileChooserController.java 0% <0%> (ø) :arrow_up:
...zeitfalle/fx/filechooser/SwingNodeFileChooser.java 0% <0%> (ø)
.../main/java/net/raumzeitfalle/fx/SwingNodeDemo.java 0% <0%> (ø)
...mzeitfalle/fx/filechooser/StandardFileChooser.java 0% <0%> (ø)
...et/raumzeitfalle/fx/filechooser/FilesListCell.java 0% <0%> (ø) :arrow_up:
...tfalle/fx/filechooser/FileSystemDialogAdapter.java 0% <0%> (ø)
...falle/fx/filechooser/StandardDirectoryChooser.java 0% <0%> (ø)
...aumzeitfalle/fx/filechooser/FileUpdateService.java 0% <0%> (ø) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37493bb...0530422. Read the comment docs.