search

Oliver-Loeffler / FXFileChooser

Custom JavaFX file chooser which allows quick manual filtering, which allows to add Path predicates as filter and which is testable using TestFX.
Apache License 2.0
44 stars 8 forks source link

Rework FileChooserView internal structure #31

Closed Oliver-Loeffler closed 4 years ago

Oliver-Loeffler commented 5 years ago

As FileChooserView only provides static factory methods, it cannot be used as an actual view. Redesign of this class is needed in order to reduce amount of code needed for view construction and in order to have a single place where the FXML is loaded and a suitable Pane (StackPane or AnchorPane) is created.

This somehow should also solve the problem in SwingFileChooser to properly pass in a DirectoryChooser which works modal compared to any underlying Swing Window.

Oliver-Loeffler commented 4 years ago

Reworked view class, so that FXML is now loaded by convention and Skin is applied automatically. No static methods exist anymore. The view is basically a pane type, where the constructure cares about FXML loading. The FXML name is determined by class name, followed by ".fxml" extension.

See 74e25f3a71e8aa03c7dd0fd1721abd63bdf8c980.