search

OliverFM / rust_light

A tensor processing library in rust.
MIT License
3 stars 0 forks source link

Currently `Tensor::from` has an `assert!` which is not correct practice #4

Open OliverFM opened 1 year ago

OliverFM commented 1 year ago

The docs say that it should never raise errors -- so best I fix this. Probably by implementing TryFrom instead

aidenfoxivey commented 1 year ago

I'm gonna start on this shortly. I think I have an idea of how to fix it.

OliverFM commented 1 year ago

I'm gonna start on this shortly. I think I have an idea of how to fix it.

Amazing! I think that this shouldn't be too bad. Have you made any progress @aidenfoxivey

aidenfoxivey commented 1 year ago

Well yeah, sort of. IE I found the point in the source code where edits need to be made. My code writing velocity has kind of crashed over time lol.