search

OliverHofkens / scryfall-telegram

Telegram bot backed by the Scryfall.com Magic:The Gathering API. Runs Serverless.
MIT License
13 stars 1 forks source link

[[ ]] lookup in group chat doesn't seem to be working #2

Closed tyler274 closed 4 years ago

tyler274 commented 4 years ago

Sorry for double post, on the right account this time.

I added the bot to a small group chat and it doesn't appear to be linking the card images as it does in 1on1 to the chat when I type say [[ nico bolas dragon god ]]

tyler274 commented 4 years ago

Never mind figured out it was the bot privacy settings

suroh1994 commented 4 years ago

How do you change the setting? Just ran into the same issue and I don't know how to change that

henges commented 4 years ago

i'm also having this issue @OliverHofkens – any idea how to change this setting for my group chat?

suroh1994 commented 4 years ago

@henges Make the bot an admin in the group. Bots cannot see regular messages, unless they are an admin. However this means they now receive every message, even if there is no [[]] in it. Just keep this in mind, if you're sharing anything personal.

OliverHofkens commented 4 years ago

Thanks for chipping in @suroh1994, that's exactly right. Now that you mention it, it seems I have a debug logging statement of incoming messages, which might be a privacy concern. I'll remove that!

OliverHofkens commented 4 years ago

Privacy issue fixed in ca4e13d55bbf114a70e161f0b6a66c09531dcb94, the logs now no longer contain incoming messages. Of course this assumes that people trust that the online bot is actually running my code in this repo, so if privacy is really a big concern, you can set up your own copy of this bot as described in the README here: https://github.com/OliverHofkens/scryfall-telegram-rs-serverless#running-it-yourself

henges commented 4 years ago

Thanks for the advice. It still isn't working even after making the bot an admin, unfortunately. I have a feeling this might be to do with the Scryfall API rather than this specific bot, though, because other bots that provide a similar function aren't working either at the moment

suroh1994 commented 4 years ago

You're right. The bot currently no longer works in our group either. It might be a problem with Scryfall. Maybe @OliverHofkens has more insight into what's going on.

OliverHofkens commented 4 years ago

Hmm, it's not related to Scryfall itself as I can still do API calls manually.

Everything I can see in the monitoring points to issue #4 , as a lot of things are timing out. I'm guessing the bots IP got throttled/blocked by Scryfall or Telegram temporarily stopped sending events to the bot because they were all timing out. I'll have a look this weekend if it's not back up by then!