search

OliverParoczai / nextcloud-unroundedcorners

An extension for making NextCloud buttons unrounded
GNU Affero General Public License v3.0
26 stars 5 forks source link

Stopped working with version 25 #10

Closed My-Random-Thoughts closed 1 year ago

My-Random-Thoughts commented 1 year ago

Hello, not sure if you have had a chance to look at NC25 - only came out yesterday, but your wonderful CSS has stopped working. I have had a quick look and all the CSS classes are still called the same so I am not sure why.

OliverParoczai commented 1 year ago

Hello!

Thank you for letting me know of the problem. I didn't update to NC 25 yet, or even knew that it had already come out. At first it looks like I will only need to bump the supported version number, but I be able to know more when my NC instance finishes the upgrade process.

I will keep this thread updated as things happen :)

Thanks again for your support, Oliver

OliverParoczai commented 1 year ago

Looks like NC25 changed more things than I thought! The pill radius options are now separated per theme instead of being in :root, and that already fixed most of the problems. There were a few other modifications as well to suit the new design, see PR #11 The update will go live in a few hours, already working on signing it for the NC apps repository.

If there are any problems you experience with the upgrade, feel free to let me know, I will be happy to fix them. My instance is pretty modified from stock, so I don't see every problem that could arise in closer-to-stock instances.

Thanks, Oliver

My-Random-Thoughts commented 1 year ago

Awesome, thank you.
Initial tests of overwriting my current css file with your changed ones looks very good.

crdxfire commented 1 year ago
image

Talk is not working - the bottom edge of the screen for entering text is hidden

NadeoGolf commented 1 year ago
image

Talk is not working - the bottom edge of the screen for entering text is hidden

I have the same issue.

OliverParoczai commented 1 year ago

Hello! Thanks for clarifying the problem, working on it! ETA a few hours

NadeoGolf commented 1 year ago

After a cache refresh, i have a other issue:

image

OliverParoczai commented 1 year ago

Hello!

Made the necessary changes to the CSS, it should work now. Please check out PR #12 and #13, if there are any problems let me know.

The update (v1.0.5) is already live on the NC app store, but will need some time for the instances to cache the new app versions (usually around 30 minutes)

NadeoGolf commented 1 year ago

Thanks for the update but I have a issue on other apps:

With your application:

image

Without:

image

OliverParoczai commented 1 year ago

Thanks, working on that next! Already have some changes in the queue for the login screen, will push it out along with this correction. I probably forgot to add the -40px correction to the body height that's required due to the navbar on top, so that's why it looks like this. I'm on my phone though, I will be able to say more when I get back home in about 2 hours.

OliverParoczai commented 1 year ago

Hello.

Just got home. Looks like most of the problems (including the hidden chat menu in Talk) stemmed from hardcoding the content body height, which would have been fine if left to it's original setting. Pushing the update now, it will go live in about half a hour. Let me know if there are any other problems or incompatibilities with other plugins, I will be available to fix them.

Thank you all for your support, Oliver

NadeoGolf commented 1 year ago

Everything seems ok, thank you for your reactivity and your support :)