search

OliverParoczai / nextcloud-unroundedcorners

An extension for making NextCloud buttons unrounded
GNU Affero General Public License v3.0
26 stars 5 forks source link

fix general rule for buttons #4

Closed karlprieb closed 2 years ago

karlprieb commented 2 years ago

fix #2

before:

image

after:

image

I think that we could align the login button as well, but I don't know if it makes sense for this app. What do you think?

OliverParoczai commented 2 years ago

Thanks for the help and the quick fix! Appreciate it.

Merging it, the code will be most likely live on the official appstore in the next 2-3 hours!

karlprieb commented 2 years ago

What about other CSS fixes line the button misalignment? Do you think it make sense to fix that when it become visible when we remove the aggressive default border radius (login button as example)?

OliverParoczai commented 2 years ago

The e-mail loading icon one? It could be done, but I'm not sure how it could be implemented in CSS only. I'm pretty new to CSS in general so I don't know that many quirks of it, but I will start searching for solutions that could be done. I was also wondering about it when I added that hack around the icon if there was a better way it could be done.

karlprieb commented 2 years ago

I don't know hahaha never noticed, I was talking about the login button, see the screenshots from thisn PR, you can notice that the button is not aligned with the login inputs, before (with rounded corners) this difference on the padding was OK, but now you can see that is not aligned. On those cases do you think we should fix that in this plugin? If so I can open another PR for that as I already have the fix on my instance. For the email loading icon I can take a look and see if my CSS skills are enough to fix that :)

OliverParoczai commented 2 years ago

Oh I see it now, good eye! If there is a fix available, you can send a PR and I can quickly add it before pushing the version out to the appstore. I was just writing a script to automate the compression and signing part just for some added convinience, so I didn't send the update out yet.

karlprieb commented 2 years ago

I'm not on my computer right now, probably I'll send the fix in 4 or 5 hours. I'll try to send the email loading fix as well :)

OliverParoczai commented 2 years ago

Okay, thank you really much for your help! :)