Check and fix all cases for scores

OliverSchacht / AutoDoubleML

2 stars 0 forks source link

Check and fix all cases for scores #5

Open PhilippBach opened 4 months ago

PhilippBach commented 4 months ago

Add, check and/or fix all cases for

PLR
- [x] IV-type ( ❌ not supported)
- [x] Partialling out ( looks good, but🕵️ to be checked)
IRM
- [x] ATE ( 🕵️ to be checked)
- [x] ATTE ( ❌ - currently overwritten by ATE)

Important:

[x] Insert the checks for the scores etc. again (were removed unintentionally in #7 )

OliverSchacht commented 3 months ago

Hi Philipp, I added the IV-type score for the $PLR$ and furtherly enabled the ATTE for the $IRM$. I did some testing, I think writing unit tests is a to-do still. For the ATTE, the learner ml_g1 is obsolete I think in the score, so I decided if the user provides time to optimize it to add this time to ml_g0 and use the same estimator for both. I think this should be fine.