search

Olivercomet / EPFExplorer

File editor for the EPF DS games, as well as other First Playable Productions titles.
GNU General Public License v3.0
20 stars 4 forks source link

Fixed control bytes for 8 channels, fixed vibrato speed #14

Closed MCJack123 closed 3 years ago

MCJack123 commented 3 years ago

This PR fixes three things:

  1. Modules with a number of channels divisible by 8 ended up skipping the first byte of the row data, causing incorrect rows for these modules (such as Mission Complete). The fix is to only increment the position if it's in between 5 bytes.
  2. Vibrato effects used to be too deep, so I fixed that by shifting the parameter by one. However, this ended up halving the speed as well as the depth. The fix is to only shift the low 4 bits down, leaving the high bits intact.
  3. The Mission Complete module uses samples that are panned all the way to the right, for some reason. I've made it so that those samples are no longer panned to the right channel.