Oliverloo0909 / pe

0 stars 0 forks source link

Add command allows unlimited spaces in the name section #4

Open Oliverloo0909 opened 1 year ago

Oliverloo0909 commented 1 year ago

Screenshot 2023-04-14 142156.png

the name field can add unlimited spaces, affecting the readability of the product. Spaces should be formatted instead since the a real scenario there is should be a maximum of one space bewteen names in a word.

input: add ... n/word (lots of spaces) secondword ... output: same format for name

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add cat command allows spaces for the category field

Screenshot 2023-04-14 143024.png

entered in the category field: c/grocery list

output of category: similar output. can cause visibility problems for users

e.g. there looks like there is a duplicate category for grocery but i just added lost of spaces till i exceeds the UI limit. (seen for point 6. and 8.)

Screenshot 2023-04-14 143442.png


[original: nus-cs2103-AY2223S2/pe-interim#2510] [original labels: severity.VeryLow type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Although similar in nature, I believe these are two separate issues because the team would have to fix both issues individually.

The first is the formatting of the category name using the command "addcat", hence the team would have to edit the AddCategoryCommand and its corresponding Parser.

Screenshot 2023-04-18 at 3.29.35 PM.png

While the second is the expense name using the command "add", so the team would have to edit the AddExpenseCommand and its corresponding Parser.

Screenshot 2023-04-18 at 3.29.10 PM.png


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** The team does not seem to have provided a reason for this downgrade. Here is my reason for disagreeing: I believe this isn't just a cosmetic issue, but an issue with the logic that the team overlooked in their parser. This mean that to fix this issue they would not have to tweak their UI component, but they would have to fix their parser, by adding perhaps error handling to prevent excess spaces. ![Screenshot 2023-04-18 at 2.47.44 PM.png](https://raw.githubusercontent.com/Oliverloo0909/pe/main/files/60d8fc4d-b4ab-4e1d-ad45-97e563dcee17.png)