search

Olivia5k / doge

wow very terminal doge
https://pypi.python.org/pypi/doge/
MIT License
961 stars 91 forks source link

Added missing space in error message #51

Closed Kaligule closed 9 years ago

Kaligule commented 9 years ago

... which lead to "Please set your system touse a UTF-8 locale." By the way: Is it by purpose that sentences end with double spaces?

Olivia5k commented 9 years ago

Good catch! I didn't see that error message much, haha.

Yes, mostly. When I wrote this I was in a period when that was important to me, especially in code. IIRC I even made vim handle that for me, and the () motions handles text better when there are two spaces. However, I was probably not ultra consistent with it and it's not as important to me anymore.

Anyways, I'd like to merge this, but please follow the commit convention of wow [...]. It's a big part of the fun with this project! :dog:

Kaligule commented 9 years ago

I totaly see how this is essential. I created a new pullrequest (#52), so I will close this one.