search

Olivia5k / doge

wow very terminal doge
https://pypi.python.org/pypi/doge/
MIT License
968 stars 89 forks source link

Switch to pyproject.toml, drop Python 2 support #70

Closed harkabeeparolus closed 9 months ago

harkabeeparolus commented 9 months ago

Hi,

I made a pyproject.toml file, switched to reading text files with importlib.resources, and verified that the package builds correctly with pip, pipx, and build. I also removed old Python 2 compatibility code.

I kept setuptools as the build backend. This could be changed, of course.

Olivia5k commented 9 months ago

I'll be honest, I haven't done any Python work in the last seven years. From a cursory web search, it looks like this is what the standard du jour is like? :sweat_smile:

Regardless, I say it sounds like a good thing, so thank you for the patch!

harkabeeparolus commented 9 months ago

I still use doge daily in all my terminal windows, which always gets funny comments from my colleagues, and I've helped several of them install it on their own accounts. 😁

I work as a Python developer, and while the packaging landscape is evolving quickly, I believe this is a safe choice.

I would be interested in working more on this project if that's ok. 😊

Olivia5k commented 9 months ago

Hah, glad to hear that it's spreading a bit of joy. :blush:

I've invited you to be a collaborator! Feel free to push some stuff! :slightly_smiling_face: