search

OlivierBlanvillain / monadic-html

Tiny DOM binding library for Scala.js
https://olivierblanvillain.github.io/monadic-html/examples/
MIT License
225 stars 24 forks source link

prevent eta-expansion in Scala 3 #121

Closed esarbe closed 3 years ago

OlivierBlanvillain commented 3 years ago

The issue is that if you define cancel with parenthesis it becomes basically unusable from scalac because forgetting parents doesn't trigger a compilation error. Also that is a big breaking change, so if a change is absolutely necessary I would prefer adding an alias instead of changing the existing cancel definition.

What's the situation with dotty? Do you get warnings with the current state?

esarbe commented 3 years ago

I get a warning that this will not be supported by dotty anymore. But you are right; it would be quite the breaking change. Let's cross this bridge when we have to.

esarbe commented 3 years ago

https://dotty.epfl.ch/docs/reference/changed-features/eta-expansion.html https://dotty.epfl.ch/docs/reference/dropped-features/auto-apply.html is the current situation with dotty in this regard.