search

OlivierBlanvillain / monadic-html

Tiny DOM binding library for Scala.js
https://olivierblanvillain.github.io/monadic-html/examples/
MIT License
225 stars 24 forks source link

renaming impure.foreach to impure.run #85

Closed bbarker closed 6 years ago

OlivierBlanvillain commented 6 years ago

:+1:

I was actually thinking about dropping the impure prefix altogether, WDYT?

bbarker commented 6 years ago

Personally, I'd be happy to leave it where it is; I don't think it should feel quite as natural to use as the rest of the API (not in the sense of it being difficult to use, but just that seeing 'impure' before it will make a newcomer think twice).

OlivierBlanvillain commented 6 years ago

Alright, thanks for the PR!