OlivierC-FR / ESP32-INAV-Radar

GNU General Public License v2.0
61 stars 22 forks source link

RFC : Add ground station mode #2

Closed stronnag closed 2 years ago

stronnag commented 3 years ago

This RFC summaries chat discussion on the above.

Some users may wish to connect a GCS (Ground Control Station) to an inav-radar node in order to view cooperating aircraft. Currently this is somewhat possible (e.g. https://github.com/stronnag/mwptools/issues/90) but is sub-optimal from both sides:

This proposal seeks to address these issues whilst maintaining a degree of integrity to the connection.

snaewe commented 3 years ago

+1 Maybe it would also be possible, to use the USB-Serial port as the connection to the PC/GCS ?

OlivierC-FR commented 3 years ago

Looks good to me ! Current code should comply with that, with the limitation that MSP_NAME is truncated to 6 chars, because OLED. MSP_STATUS and _BOXIDS are not used, and I added a check to not MSP_RAW_GPS a GCS.

About the serial over the USB port, it's on the to-do list. It was in there at some point, a long time ago, aswell bluetooth, but I removed it all because that's what I do, remove things :)

stronnag commented 3 years ago

Olivier, sure that MSP_STATUS is not used for GCS? In 2.0, the check is still curr.host != HOST_NONE rather than curr.host == HOST_INAV (src/main.cpp#940), unless I'm not seeing some prior if(){}.

So it's still asking for ANALOG and STATUS, neither of which are relevant to a GCS.

OlivierC-FR commented 3 years ago

Olivier, sure that MSP_STATUS is not used for GCS? In 2.0, the check is still curr.host != HOST_NONE rather than curr.host == HOST_INAV (src/main.cpp#940), unless I'm not seeing some prior if(){}.

So it's still asking for ANALOG and STATUS, neither of which are relevant to a GCS.

you're 100% right, forgot this one, I force-pushed the fix, the check is done at 944, in the next IF