OlivierCC / sp-client-custom-fields

Web Site: https://oliviercc.github.io/sp-client-custom-fields
MIT License
114 stars 57 forks source link

PropertyFieldRichTextBox bug #10

Open michaeldybal opened 7 years ago

michaeldybal commented 7 years ago

Issue 1. (version 1.3.5-1.3.7)

  1. use webpart with PropertyFieldRichTextBox on property pane
  2. edit webpart, configure
  3. works nice. cloce
  4. configure -> breaks down gif: https://image.prntscr.com/image/CxIxSdz6S0_ouMsucLhraw.gif

Issue 2. Conflict with nodes that have contenteditable='true'

  1. use webpart with PropertyFieldRichTextBox on property pane
  2. add "Content Editor" webpart, set some content
  3. edit your webpart, configure
  4. "Content Editor" webpart lose content gif: https://image.prntscr.com/image/W48F9rJtSw63QC0dv-stuA.gif
OlivierCC commented 7 years ago

Hi @michaeldybal,

Thanks for this bug report.

Some questions please:

Thanks a lot by advance, regards,

Olivier

kmartindale commented 7 years ago

Hey @OlivierCC I'm also seeing this in classic mode on a publishing site.

If I have publishing page content styled as soon as I edit a webpart and click configure (if that webpart has the rich text editor in the prop pane) it just wipes all the styles in the page content area.

I've been digging into this for a bit and figured I'd come see if anyone else had mentioned it to you. Do you have any ideas on a fix? It seems like when ckeditor is being loaded its just tacking itself on to all textareas on the screen not just the ones that we've told it to.

Any advice is welcome. thanks!

p.s. I've tried destroying the other ckeditor instances that it seems to create when the script gets loaded, but that's already too far down the chain. styles are already gone.