OlivierCC / spfx-40-fantastics

This package is a sample kit of Client Side Web Parts built on the SharePoint Framework SPFx. You can find here different kind of high visual web parts as carousel, images galleries, animations, map, editors, etc.
MIT License
408 stars 279 forks source link

Custom Classic Pages #10

Open MrCarrick opened 7 years ago

MrCarrick commented 7 years ago

Love the web parts, a wonderful example of what's possible with SPFx.

Testing these with pages built in custom page layouts and master pages proves problematic unfortunately. The web parts only fully render around 1 out of 10 page reloads.

In out of the box classic pages, everything works fine every time.

Is there anything we can do to ensure all the required resources are loaded every time?

OlivierCC commented 7 years ago

Thanks for this feedback @MrCarrick. Do you have more info in your browser console about an error? Do you use jQuery in your custom master page ?

Regards,

Olivier

MrCarrick commented 7 years ago

Hi @OlivierCC we are using jQuery in our custom master page.

We're now experiencing the following which is new behaviour...

[SPWebPartErrorCode.ScriptLoadError]:

Unable to load web part WebPart.TabsWebPart.g_e586b00d_1ec8_4843_bc00_50e0edc227e1,Error: ***Failed to load component "0824a209-e4f0-45a8-b630-99e5d72df5f5" (TabsWebPart).

Original error: ***Failed to load URL 'https://spfx40fantastics.azureedge.net/spfx40fantastics/tabs.bundle_1e9490199c5babf38ab93c4c9df1db4c.js' for resource 'tabs.bundle' in component '0824a209-e4f0-45a8-b630-99e5d72df5f5' (TabsWebPart). There was a network problem.

This may be a problem with a HTTPS certificate. Make sure you have the right certificate. script resources due to: {1}.

***CALLSTACK:

t@https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-03-31.004/classic-pages-assembly_en-us_d4cfb9b364d8f92f51e075c1eb2ddb73.js:109:25211
t@https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-03-31.004/classic-pages-assembly_en-us_d4cfb9b364d8f92f51e075c1eb2ddb73.js:102:98683
spModuleLoader</__WEBPACK_AMD_DEFINE_RESULT__</</u</t.create@https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-03-31.004/classic-pages-assembly_en-us_d4cfb9b364d8f92f51e075c1eb2ddb73.js:102:99126
spModuleLoader</__WEBPACK_AMD_DEFINE_RESULT__</</I</e.prototype._handleModulePromiseRejection@https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-03-31.004/classic-pages-assembly_en-us_d4cfb9b364d8f92f51e075c1eb2ddb73.js:109:906611
spModuleLoader</__WEBPACK_AMD_DEFINE_RESULT__</</I</e.prototype.loadWebPart/</<@https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-03-31.004/classic-pages-assembly_en-us_d4cfb9b364d8f92f51e075c1eb2ddb73.js:109:896756

I notice the latest release disables this web part for classic pages (it uses the additional editor despite presence of the ribbon). With that said, I guess we're now an "unsupported" configuration! :)