search

OlivierCC / spfx-40-fantastics

This package is a sample kit of Client Side Web Parts built on the SharePoint Framework SPFx. You can find here different kind of high visual web parts as carousel, images galleries, animations, map, editors, etc.
MIT License
412 stars 277 forks source link

Markdown tables not being converted #23

Closed guzzd closed 7 years ago

guzzd commented 7 years ago

Tables doesn't get converted. Is there any way to turn on and off these options for markdown/showdown?

OlivierCC commented 7 years ago

Hi @guzzd,

This web part uses showdown JS (https://github.com/showdownjs/) to render the markdown. I checked in the showdown documentation, and to support tables we need to add a specific option (see doc about tables here: https://github.com/showdownjs/showdown/wiki/Showdown's-Markdown-syntax).

Today, the web part does not use this option. I will add it the next release.

Thanks you for this bug report, regards,

Olivier

OlivierCC commented 7 years ago

Hi @guzzd,

I can confirm that the next version of the package will contain the fix. If you are using the prepackaged file, I will pushing it very soon. If you are using the code version directly, you can get the fix here (line 116): https://github.com/OlivierCC/spfx-40-fantastics/blob/master/src/webparts/markdown/MarkdownWebPart.ts

Olivier

guzzd commented 7 years ago

Excellent, thanks for that!