search

OlivierCC / spfx-40-fantastics

This package is a sample kit of Client Side Web Parts built on the SharePoint Framework SPFx. You can find here different kind of high visual web parts as carousel, images galleries, animations, map, editors, etc.
MIT License
412 stars 277 forks source link

Fix `gulp serve` failed #61

Open tsekityam opened 6 years ago

tsekityam commented 6 years ago

This PR fixed three issues that makes gulp serve failure.

The issues are:

  1. Error - typescript - node_modules/@microsoft/sp-loader/node_modules/@types/react/index.d.ts(39,25): error TS1005: ',' expected. Reason: typescript module being used is not compatible with the @types/react module being used Fixed by 49c4679 See also: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/17459

  2. Error - typescript - src/webparts/messageBar/MessageBarWebPart.ts(111,49): error TS2345: Argument of type '{ label: string; initialValue: string; inline: false; minHeight: number; mode: string; onProperty...' is not assignable to parameter of type 'IPropertyFieldRichTextBoxProps'. Reason: upstream introduce a new property, with is not compatible with our code. Fixed by c5808e1 See also: https://github.com/OlivierCC/sp-client-custom-fields/commit/0f53db7a374434ffd0e75fb0c181869a31d2e51b

  3. Error - typescript - src/webparts/simplePoll/components/SimplePollWebPartHost.tsx(208,15): error TS2540: Cannot assign to 'selectedValue' because it is a constant or a read-only property. Reason: we should not set state directly. Fixed by 7bb4de2 See also: State and Lifecycle - React

tsekityam commented 6 years ago

I believe my patch should also fix #48, #49 and #57