OlivierCC / spfx-40-fantastics

This package is a sample kit of Client Side Web Parts built on the SharePoint Framework SPFx. You can find here different kind of high visual web parts as carousel, images galleries, animations, map, editors, etc.
MIT License
412 stars 277 forks source link

Valid App Package = No #7

Closed robhasos closed 7 years ago

robhasos commented 7 years ago

Hi,

I've tried to install the sppkg in the App Catalog but it doesn't seem to recognise the package. While there are no upload errors, "Valid App Package" is set to No, the product Id doesn't look right and I can't add the app to any site. See the image below...

image

Any ideas what's wrong?

OlivierCC commented 7 years ago

Thanks @robhasos for your feedback. I can not reproduce it on my test tenants. The SharePoint Framework is currently in rolled out to all 0365 tenancies, may be your tenant is not yet ready. You can try to deploy it later (wait few days) and I will try to find your a simple process to check what is your tenant status.

OlivierCC commented 7 years ago

@robhasos, an "easy" way to check the version of the SPFx on your tenant can be:

  1. Create a "modern site" (for example create a new O365 group with a SharePoint site attached)
  2. Go to a page (home for example) and open your browser debugguer with the Network tab
  3. Check the JS files loaded, and verify what is the URL of the JS files from the CDN: the good SPFx version shoud have a "2017-02-17" value in path (see the attached picture bellow).

spfxv1check

Thanks a lot by advance if you can test it and report to me if this is the explanation. Regards, Olivier

robhasos commented 7 years ago

Hi Olivier,

Looks like it is enabled... <link href="https://spoprod-a.akamaihd.net/files/sp-client-prod_2017-02-17.019/sp-pages.bundle_en-us_29d9d18da3b22ea10154880027f99253.js" rel="preload" as="script">

Should be as we are First Release tenant.

I've contacted support to see whether SPFX has been properly rolled out to our tenant.

Thanks,

Rob

OlivierCC commented 7 years ago

Thanks a lot. I will continue to investigate, stay tuned.

summerprisocksonos commented 7 years ago

I'm having the exact same experience as @robhasos when trying to install to the app catalog.

robhasos commented 7 years ago

O365 Support have told me the rollout is still in progress.

OlivierCC commented 7 years ago

OK thanks for your answer @robhasos. Please tell me when your tenant will be ready if it's working or not.

baskb commented 7 years ago

Also my tenant has the 02-17 JS files, but can't install the package in my app catalogue

summerprisocksonos commented 7 years ago

yes, thanks @robhasos -- that response is so disappointing, but not at all surprising. I feel like they lean on that vague response way too much these days.

marcelhaasIO commented 7 years ago

Hi @OlivierCC

Having the same issue here with app installation:

sss

Correct #SPFx version is loaded, but App has no ID, Product ID and says that app package is not valid.

Thx for your help!

marcelhaasIO commented 7 years ago

https://github.com/SharePoint/sp-dev-docs/issues/276 as discussed here also, I think the issue is that, we are somehow stil not completely rolled out when it comes to #SPFx. References in pages are there, but it looks like smth is missing. We have first release activated only for several users? Should it be activated for all maybe? Whats your setting there? As it's GA now, I don't see the need to set first release for this matter. Or am I wrong here?

marcelhaasIO commented 7 years ago

After turning on First Release for all Users, I was able to deploy and activate the Webparts. Thank you!

mistergee2010 commented 7 years ago

Hi, Completely new to Office 365. But really hope to use the coverflow web part for my school community. I am experiencing what all others are stating here. I however don't fully understand what the fix is. Can someone break it down into basic step by step for us NOOBs out there? Thanks

OlivierCC commented 7 years ago

Hi @mistergee2010, there is no specific fix: you need to wait that the new SharePoint Framewok rollout is completed. A possibility to go faster is to use the functionality called 'First release' for all your users. This means that your tenant receives updates before the normal date. You can read more information about how to configure it here: https://support.office.com/en-us/article/Set-up-the-Standard-or-First-Release-options-in-Office-365-3b3adfa4-1777-4ff0-b606-fb8732101f47?ui=en-US&rs=en-US&ad=US

mistergee2010 commented 7 years ago

?Thanks for replying we will have a look at it


From: Olivier Carpentier notifications@github.com Sent: Tuesday, March 7, 2017 12:24 PM To: OlivierCC/spfx-40-fantastics Cc: Troy Gordon; Mention Subject: Re: [OlivierCC/spfx-40-fantastics] Valid App Package = No (#7)

Hi @mistergee2010https://github.com/mistergee2010, there is no specific fix: you need to wait that the new SharePoint Framewok rollout is completed. A possibility to go faster is to use the functionality called 'First release' for all your users. This means that your tenant receives updates before the normal date. You can read more information about how to configure it here: https://support.office.com/en-us/article/Set-up-the-Standard-or-First-Release-options-in-Office-365-3b3adfa4-1777-4ff0-b606-fb8732101f47?ui=en-US&rs=en-US&ad=US

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OlivierCC/spfx-40-fantastics/issues/7#issuecomment-284618171, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZBcKIwpbNfitB6VpQg_pHUnBGrLcZSjks5rjNwJgaJpZM4MPTr7.

baskb commented 7 years ago

Waiting until my tenant was ready fixed the issue. Things started working for me yesterday.

Love the modern webparts!!! Thanks

robhasos commented 7 years ago

If better try again now!


From: Bastiaan Kortenbout notifications@github.com Sent: Wednesday, March 15, 2017 2:57:37 PM To: OlivierCC/spfx-40-fantastics Cc: Rob Henwood; Mention Subject: Re: [OlivierCC/spfx-40-fantastics] Valid App Package = No (#7)

Waiting until my tenant was ready fixed the issue. Things started working for me yesterday.

Love the modern webparts!!! Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OlivierCC/spfx-40-fantastics/issues/7#issuecomment-286767913, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKxqsyv2g6YQe5CWh_z6sbwyQrHD68nZks5rl_xhgaJpZM4MPTr7.

robhasos commented 7 years ago

Whoop! Works for me too now.

@OlivierCC , thanks for your great work on these webparts.