Initial find script - Githubissues

OlivierLDff / asio.cmake

Small CMake wrapper to add asio with a simple FetchContent.

MIT License

17 stars 8 forks source link

Initial find script #14

Open Ryanf55 opened 1 year ago

Ryanf55 commented 1 year ago

This is the PR for #13, currently in draft to garner feedback.

Let's somehow test the RST docs are correct
How are we expecting a user to install FindASIO.cmake
TODO: Add this to CI
TODO: Add cmake pre-commit hook to continue to lint the file

Note: This work was done on behalf of AeroVironment Inc.

OlivierLDff commented 1 year ago

Looks fine, waiting for CI & doc 🚀

Ryanf55 commented 1 year ago

Found a bug - if any of the major, minor, or patch versions are 0, the find_package_handle_standard_args reports the variables as not found.

OlivierLDff commented 1 year ago

That is odd, because 0.0.1 shoudl be a valid version or 1.0.0

Ryanf55 commented 1 year ago

ASIO_VERSION_PATCH

Correct, that is a valid version, however I don't think you are supposed to put ASIO_VERSION_PATCH in the required variables. The math call should never fail.

We can assume if ASIO_VERSION exists, the other related version variables should work.

OlivierLDff commented 1 year ago

Seems fair