feat: refactor and more - Githubissues

OlivierLDff / asio.cmake

Small CMake wrapper to add asio with a simple FetchContent.

MIT License

18 stars 9 forks source link

feat: refactor and more #17

Open carlocorradini opened 2 months ago

carlocorradini commented 2 months ago

Fix #16

Added

Option ASIO_NO_DEPRECATED to disables Asio deprecated interfaces and functionality
Target properties CXX_STANDARD 11, CXX_STANDARD_REQUIRED ON and CXX_EXTENSIONS OFF
GitHub workflow to update license year
GitHub Dependabot
Visual Studio Code configuration directory
EditorConfig configuration file
Git Attributes

Changed

CMake library INTERFACE since it is header only
Error if CMake version is lower than 3.14
Default Asio tag set to asio-1-31-0
Avoid including CPM if already available and initialized
Renamed CPM.cmake to get_cpm.cmake
Updated CPM to v0.40.2
Updated .cmake-format
More .gitignore entries
Keep a Changelog for changelog
Renamed file License to LICENSE
Renamed file Readme.md to README.md
Renamed file Changelog.md to CHANGELOG.md

PS: In README.md I've set the examples to use asio.cmake as version v1.3.0. Update accordingly if the version changes

OlivierLDff commented 2 months ago

Hi thank you for the PR but this is too much at once, I'm ok about most of the changed, just I would like to have a PR per new line that you added. This makes it easier to review, for external user to see what changed, and to find error/problem origin in the future using git bisect.

Could you separate in different PR all the changes?