Creation new HomePage - Githubissues

OlivierTD / team-rocket

Team Rocket working on OSS AntennaPod

MIT License

1 stars 1 forks source link

Creation new HomePage #157

Closed SaiShan closed 6 years ago

SaiShan commented 6 years ago

This fragment will be displayed within one of the two tabs of the home page.

User Story: #143 Task: #154

SaiShan commented 6 years ago

Task #155

SaiShan commented 6 years ago

Task #156 ( 1 of 2)

davidlegare commented 6 years ago

Commit messages are not description enough, "removing other part content", "refactor", "small changes" are too vague (we lose points because of this).
References are missing in the commits.

SaiShan commented 6 years ago

As for the names of the commit, will be careful from now on.

The reference for the associated tasks within the commit message is not quite working on my end with git bash.

OlivierTD commented 6 years ago

All you have to do to reference a task is using # with a number. In git bash, you won't see any reference pop out but it will show when you look on Github.

davidlegare commented 6 years ago

There are conflicts since the updates to master, please resolve these.

OlivierTD commented 6 years ago

The goal of the PR is achieved so I will approve it. Take note that some improvement could be done on the home page to make it more appealing.