search

OlivierTD / team-rocket

Team Rocket working on OSS AntennaPod
MIT License
1 stars 1 forks source link

Issue #115- Created functionality for renaming queues #160

Closed 23jams closed 6 years ago

23jams commented 6 years ago

On long click of the queue name a dialog appears, which if filled in, will rename the queue with entered information. If canceled, nothing will occur.

-Added rename queue functionality

23jams commented 6 years ago

Realized I shouldn't have hard coded the string value, fixing it now. Edit(fixed)

OlivierTD commented 6 years ago

We need another person to review @davidlegare

23jams commented 6 years ago

Made corrections according to requested changes. I first attempted to make it a context menu, but could not manage to get it to load properly. Even though I registered it and coded it similar to how I got it running in the remove method, it simply wouldn't appear on long click.

But even with on context menu, the only bonus would be to provide more options later on. Otherwise, the functionality would be very similar. A nice UI enhancement would be to add drawables for on press or on hold, to highlight that its pressed. But this was not part of original functionality. So even with on context menu, there would be no feedback for the user until the menu opens.

One potential change would be to attach it to an edit/rename button, to make it more obvious. But in general, this feature I view more as an accelerator for the expert user, and not specifically tailored for the new user.