search

OlivierTD / team-rocket

Team Rocket working on OSS AntennaPod
MIT License
1 stars 1 forks source link

Confirm queue deletion #98

Closed OlivierTD closed 6 years ago

OlivierTD commented 6 years ago

A confirmation message is shown to the user asking them if they really want to delete the queue or if they made a mistake. This provides error tolerance to our design.

I forgot to reference the issue in my commit again :fearful:

Issues related #38 #96

Please merge #97 before merging this since this branch includes the changes that were done in #97 thanks.

OlivierTD commented 6 years ago

There will not be any accidental additions. The extra stuff is from the branch that you just merged. As you can see, Github does not see any conflicts and it's literally the code that was used in the branch that was just merged.

It is safe to merge.

davidlegare commented 6 years ago

Good point about it being conflict free, I'll approve the PR. Just need @23jams to merge.