OllieWP / ollie

A finely-crafted WordPress block theme by Mike McAlister
https://olliewp.com
GNU General Public License v3.0
334 stars 44 forks source link

Make an easy way to add more fonts via the editor #103

Closed jonathangood closed 6 months ago

jonathangood commented 6 months ago

Is your feature request related to a problem? Please describe. I've been trying to figure out the easiest way to add custom fonts or any other ones to the theme - and haven't been successful yet.

Describe the solution you'd like It would be great to be able to add a few other fonts (or font pairings) to the theme without having to do custom coding

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context As a consolation - if you could show an example of how to do it in the documentation that would be awesome too.

mikemcalister commented 6 months ago

Hey Jonathan!

Thanks for the feedback. We likely won't be adding any font features because a full-fledged font management system is coming to WordPress soon! It was actually slated for the next release in a few weeks, but got pushed back to 6.5 for further improvement.

Unfortunately, some of those popular Google font plugins don't work well with block themes. Because of GDPR privacy concerns, it's also not suggested to load fonts remotely like we used to. Instead, they want you to add them to your theme so the fonts can be loaded locally.

Because of that, adding fonts is a little more tricky these days! If you want to add fonts before that new interface comes, you'll probably want to use a child theme (which you can download here), and use the Create Block Theme plugin to help adding fonts to your theme. That plugin provides an interface for adding fonts to block themes.

The reason for the child theme is because it adds fonts directly to your theme. Without a child theme, those fonts would get wiped out every time you updated the Ollie theme. Hope that helps!

jonathangood commented 6 months ago

Mike, thank you for the detailed and thoughtful response. I really appreciate this. I'll try out the child theme. Thanks!

On Mon, Oct 30, 2023 at 11:40 AM Mike McAlister @.***> wrote:

Hey Jonathan!

Thanks for the feedback. We likely won't be adding any font features because a full-fledged font management system is coming to WordPress soon! It was actually slated for the next release in a few weeks, but got pushed back to 6.5 for further improvement.

Unfortunately, some of those popular Google font plugins don't work well with block themes. Because of GDPR privacy concerns, it's also not suggested to load fonts remotely like we used to. Instead, they want you to add them to your theme so the fonts can be loaded locally.

Because of that, adding fonts is a little more tricky these days! If you want to add fonts before that new interface comes, you'll probably want to use a child theme (which you can download here https://github.com/OllieWP/ollie/releases/latest/download/ollie-child.zip), and use the Create Block Theme plugin https://wordpress.org/plugins/create-block-theme/ to help adding fonts to your theme. That plugin provides an interface for adding fonts to block themes.

The reason for the child theme is because it adds fonts directly to your theme. Without a child theme, those fonts would get wiped out every time you updated the Ollie theme. Hope that helps!

— Reply to this email directly, view it on GitHub https://github.com/OllieWP/ollie/issues/103#issuecomment-1785830120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE7462TQQMH3PDSM2NXKKTYB7YCHAVCNFSM6AAAAAA6M7IVCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHAZTAMJSGA . You are receiving this because you authored the thread.Message ID: @.***>

-- Jonathan Good tel: 650-863-3823