search

OllieWP / ollie

A finely-crafted WordPress block theme by Mike McAlister
https://olliewp.com
GNU General Public License v3.0
334 stars 44 forks source link

Can't disable link text-decoration underline using theme style editor #104

Open mikejcoop opened 6 months ago

mikejcoop commented 6 months ago

Describe the bug I want to disable the default behaviour of all links being underlined in a non hover/active state. To do this I have tried going to the site editor > styles > links and setting decoration to none.

However, the Ollie theme style.css stylesheet has text-decoration: underline set the theme uses this instead.

To Reproduce Steps to reproduce the behavior:

  1. Go to Site Editor > Styles > Links
  2. Set text decoration to none
  3. View any page with a link
  4. See links with underline

Expected behavior I should be able to use the style from the site editor. See screenshot below, where you can see the site editor style being overridden by the theme style.css rule.

Screenshots

image

Additional context I'm very new to the Site Editor experience, so please let me know if I have missed something.

mikemcalister commented 6 months ago

Hi Mike,

Thanks for the heads up! I'll take a closer look at this and see if we can do this via theme.json now. I've just gone on a parental leave break, so it may just be a week or two before I can look at this closer. Stay tuned!