Add empty spool weight to the spool profile

OllisGit / OctoPrint-FilamentManager

OctoPrint plugin to manage your filament inventory

GNU Affero General Public License v3.0

53 stars 24 forks source link

Add empty spool weight to the spool profile #47

Open colossatr0n opened 3 years ago

colossatr0n commented 3 years ago

It would be useful to be able to store the empty spool weight in the spool profile. That way I could weigh a brand new spool, enter the total weight, and enter the empty spool weight. The remaining weight would be calculated by subtracting the empty spool weight and the used weight from the total weight.

This can be done without the feature just by subtracting the empty spool weight from the measured total weight manually, but that requires the user to store the empty spool weight data for a given filament brand outside of the filament manager plugin. Doable, but not preferred.

ldiegos commented 3 years ago

Hi, I desire also this functionality, but why won't you fix it @OllisGit ?

Thank you so much for your work!

OllisGit commented 3 years ago

Hi @ldiegos, sorry for just adding the Label 'wontfix" without commenting it.

Adding a new field to the database is not an easy task, because:

I need to make sure that the current database (local or PostgreSQL) upgrade in the same way and no data got lost
Some checks in the UI needs to be implemented
Calculation needs to be implemented and tested

Overall, this enhancement will take round about 2-3days (a 8h) to implement...and investing this time in the SpoolManager-Plugin is maybe better.

But if you (or other) are willing to raise a "Pull Request" I am more than happy to review and release it.

ldiegos commented 3 years ago

Hi @OllisGit Ok, lets wait until spoolManager could be able to handle the PostgreSQL database(the existent one with this plugin)