Confirm selected spool popup must be opened twice

OllisGit / OctoPrint-FilamentManager

OctoPrint plugin to manage your filament inventory

GNU Affero General Public License v3.0

52 stars 24 forks source link

Confirm selected spool popup must be opened twice #64

Open StephanBeutel opened 3 years ago

StephanBeutel commented 3 years ago

Describe the bug I activated the "Confirm selected spool popup". On every print I have to open it two times as the first time there is no dropdown to select the spool.

Steps to reproduce

Activate "Show dialog to confirm selected spools before starting/resuming the print job"
Upload gcode file (file list must be empty before upload)
Click in "Start print"
Dialog does not show dropdown to select the spool

I delete the gcode files after printing. So mostly I start with an empty file list. Same behavior is also if you do a server restart. On first print the popup has to be opened twice.

Expected behavior Dialog shows the dropdown on first opening.

Did the same happen when all other 3rd party plugins are disabled? Yes

Log file Drag and drop the octoprint.log here.

Screenshots

OllisGit commented 3 years ago

Hi @StephanBeutel, is the spool-dropdown in the sidebar filled? Please make a screenshot of the "missing selection-box".

Internal: There are a couplle of conditions for showing the selection-list:

!$root.core.bridge.allViewModels.printerStateViewModel.isPrinting() &&
$root.core.bridge.allViewModels.loginStateViewModel.isUser()

StephanBeutel commented 3 years ago

Hi, I already added screenshots, but for some reason they are missing.

The Dropdown in the sidebar is filled. I can also reproduce it by just disconnect and reconnect the printer. Even when the list is filled with old prints. So the first start of a print job after the printer is connected does not show the dropdown.

I know in the screenshot you can see, that I use some more plugins, but I already deactivated all plugins before I created this issue. Don't want to do this again, as the behavior is the same.

When I close this popup and just click on "start print" again, then the dropdown appears.

OllisGit commented 2 years ago

Hi @StephanBeutel, I analyse the issue again and I could recreate it on my local system.

Unfortunately at the moment I have no idea how to solve this issue.

Background:

The confirm-dialog needs the information which tools (0...x) were needed for the selected file
For this reason it looks into the metadata.json file in the upload folder
The file is updated with the necessary informations (filament-section) after the MetaDataAnalysing-Process of OP is finished and this could take a while, depending on the file size. Also, it depends what strategy is selected in the OP-Settings. Try to switch to always

So, if this not help...you need to be patient...or setup a faster op-server...I could add an indicator that shows the status of MetaDataAnalysing-Process, but this is just a visual representation and did not solve the issue, sorry!

StephanBeutel commented 2 years ago

Hi, I realized that when I load the model first just by clicking on it, then I can select print and the dialog is shown correctly. Only if no model is selected for print and by using directly the print button, then the dialog needs to be opened twice.

Right now I'm in a foreign country until end of the year. I first can use my printer again around end of January.