search

OllisGit / OctoPrint-PrintJobHistory

OctoPrint Plugin stores all print-job informations of a print in a database
138 stars 40 forks source link

Plugin triggers a "please reload" dialog after every job #200

Open dimo414 opened 2 years ago

dimo414 commented 2 years ago

I've been noticing for a while now that if I leave OctoPrint open for too long it ends up displaying a "Please Reload" overlay dialog even though nothing should have changed with the server. A few searches found similar reports like https://github.com/OctoPrint/OctoPrint/issues/2950 which suggest the issue is plugins writing to the OctoPrint config unnecessarily. After snapshotting my config for a little while I hit another dialog today and this plugin appears to be a culprit:

$ diff -u /tmp/octoprint-config-2022-07-31_05.53.57.yaml /tmp/octoprint-config-2022-08-02_05.59.26.yaml
--- /tmp/octoprint-config-2022-07-31_05.53.57.yaml      2022-07-31 05:53:57.356692508 +0000
+++ /tmp/octoprint-config-2022-08-02_05.59.26.yaml      2022-08-02 05:59:26.685099734 +0000
@@ -34,7 +34,7 @@
     pluginCheckActivated: false
     preferedImageSource: camera
     selectedFilamentTrackerPlugin: SpoolManager Plugin
-    showPrintJobDialogAfterPrint_jobId: 251
+    showPrintJobDialogAfterPrint_jobId: 253
   SlicerEstimator:
     _config_version: 2
     pdp: '1'

I'm guessing this job ID value should be stored somewhere other than the OctoPrint config, since updating it seems to trigger this "please reload" overlay unnecessarily.

github-actions[bot] commented 2 years ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 2 years ago

AFAIK this is still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 2 years ago

AFAIK this is still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 2 years ago

@OllisGit I don't mind this bug sitting idle, I'm sure you have better things to do, but could you turn off the auto-closer? I don't know what else to do than ping this every month which is just obnoxious for everyone involved.

david-dasilva commented 1 year ago

Please store the current job id elsewhere to prevent this reloading. I'm not familiar with Octoprint plugins but I will try to take a look when I find the time.