OllisGit / OctoPrint-PrintJobHistory

OctoPrint Plugin stores all print-job informations of a print in a database
139 stars 41 forks source link

No thumbnail in history list if spaces/accents in filename #219

Open PyBonnetainNesterenko opened 1 year ago

PyBonnetainNesterenko commented 1 year ago

(still using OctoPrint 1.8)

Hello, The plugin works great, but the thumbnails are not displayed if the printed filename contains (at least) spaces and accents. Which is annoying.

Fist with accents : History-1

A proper display and print : History-2

Renamed the previous file to add some spaces (and printed/canceled it, it's only to show the problem) : History-3

dojohnso commented 8 months ago

https://github.com/OllisGit/OctoPrint-PrintJobHistory/pull/226

Check the fix in this PR, should take care of this. The author of this repo doesn't seem to pay attention anymore but you can update it manually per the steps I listed there.

PyBonnetainNesterenko commented 8 months ago

As far as my limited tests show, this suggestion solves the problem. Thanks !