OllisGit / OctoPrint-SpoolManager

Plugin for managing Spools
169 stars 57 forks source link

Plugin triggers a "please reload" dialog after every job #285

Closed dimo414 closed 6 months ago

dimo414 commented 2 years ago

I've been noticing for a while now that if I leave OctoPrint open for too long it ends up displaying a "Please Reload" overlay dialog even though nothing should have changed with the server. A few searches found similar reports like https://github.com/OctoPrint/OctoPrint/issues/2950 which suggest the issue is plugins writing to the OctoPrint config unnecessarily. After snapshotting my config for a little while I hit another dialog today and this plugin appears to be a culprit:

$ diff -u /tmp/octoprint-config-2022-07-31_05.53.57.yaml /tmp/octoprint-config-2022-08-02_05.59.26.yaml
--- /tmp/octoprint-config-2022-07-31_05.53.57.yaml      2022-07-31 05:53:57.356692508 +0000
+++ /tmp/octoprint-config-2022-08-02_05.59.26.yaml      2022-08-02 05:59:26.685099734 +0000
@@ -49,7 +49,7 @@
     hideInactiveSpoolsInSidebar: false
     selectedSpoolDatabaseId: 3
     selectedSpoolsDatabaseIds:
-    - 1
+    - 34
   _disabled:
   - discovery
   - filamentmanager

I'm guessing this spool ID value should be stored somewhere other than the OctoPrint config, since updating it seems to trigger this "please reload" overlay unnecessarily.

github-actions[bot] commented 2 years ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 2 years ago

AFAIK this is still an issue.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

AFAIK this is still an issue.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

@OllisGit I don't mind this bug sitting idle, I'm sure you have better things to do, but could you turn off the auto-closer? I don't know what else to do than ping this every month which is just obnoxious for everyone involved.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

mdziekon commented 1 year ago

I'm also affected by this issue, especially since I'm running it on a rather slow to "reload" OrangePi Zero 2, where the "reload" might result in the printing process getting interrupted for a brief moment (which might introduce artifacts in the print).

I've observed that it shows up:

This leads me to belivieve that there must be some sort of mechanism of re-verification of the config loaded by the browser and as stored on the server. It's a bit weird that the "change originator" (eg. desktop browser tab) has to reload the config, even though the config was actually changed by that originator. This is probably something that should be investigated in Octoprint.

However, if possible, it would be great to keep the spool id selection outside of the main config file to prevent it being in need of reloading.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

😞

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

😞

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 1 year ago

.

github-actions[bot] commented 11 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 11 months ago

.

github-actions[bot] commented 10 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 10 months ago

.

github-actions[bot] commented 9 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 9 months ago

.

github-actions[bot] commented 8 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

dimo414 commented 8 months ago

.

github-actions[bot] commented 7 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

github-actions[bot] commented 6 months ago

This issue was closed, because it has been already marked for 10 days with no activity.