OllisGit / OctoPrint-SpoolManager

Plugin for managing Spools
168 stars 58 forks source link

fix: pillow version string in setup.py #327

Closed HTXF-g closed 1 year ago

HTXF-g commented 1 year ago

when trying to install spoolmanager i got those errors in the plugin_pluginmanager_console.log. It seems there was a "," missing in the pillow version string. Now installation works.

plugin_pluginmanager_console.log:

—————

...
2023-04-27 13:06:28,668 ! Traceback (most recent call last):
2023-04-27 13:06:28,668 ! File "<string>", line 2, in <module>
2023-04-27 13:06:28,668 ! File "<pip-setuptools-caller>", line 34, in <module>
2023-04-27 13:06:28,669 ! File "/tmp/pip-req-build-bkevnds4/setup.py", line 103, in <module>
2023-04-27 13:06:28,669 ! setup(**setup_parameters)
2023-04-27 13:06:28,669 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/__init__.py", line 108, in setup
2023-04-27 13:06:28,670 ! return distutils.core.setup(**attrs)
2023-04-27 13:06:28,670 ! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-04-27 13:06:28,670 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 185, in setup
2023-04-27 13:06:28,670 ! return run_commands(dist)
2023-04-27 13:06:28,671 ! ^^^^^^^^^^^^^^^^^^
2023-04-27 13:06:28,671 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
2023-04-27 13:06:28,672 ! dist.run_commands()
2023-04-27 13:06:28,672 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
2023-04-27 13:06:28,672 ! self.run_command(cmd)
2023-04-27 13:06:28,673 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/dist.py", line 1213, in run_command
2023-04-27 13:06:28,673 ! super().run_command(command)
2023-04-27 13:06:28,673 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
2023-04-27 13:06:28,674 ! cmd_obj.run()
2023-04-27 13:06:28,674 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/bdist_wheel.py", line 395, in run
2023-04-27 13:06:28,674 ! self.egg2dist(self.egginfo_dir, distinfo_dir)
2023-04-27 13:06:28,674 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/bdist_wheel.py", line 534, in egg2dist
2023-04-27 13:06:28,675 ! pkg_info = pkginfo_to_metadata(egginfo_path, pkginfo_path)
2023-04-27 13:06:28,675 ! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-04-27 13:06:28,675 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/metadata.py", line 160, in pkginfo_to_metadata
2023-04-27 13:06:28,676 ! for key, value in generate_requirements({extra: reqs}):
2023-04-27 13:06:28,676 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/metadata.py", line 138, in generate_requirements
2023-04-27 13:06:28,677 ! for new_req in convert_requirements(depends):
2023-04-27 13:06:28,677 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/metadata.py", line 103, in convert_requirements
2023-04-27 13:06:28,677 ! parsed_requirement = Requirement(req)
2023-04-27 13:06:28,678 ! ^^^^^^^^^^^^^^^^
2023-04-27 13:06:28,678 ! File "/home/ender/OctoPrint/venv/lib/python3.11/site-packages/wheel/vendored/packaging/requirements.py", line 37, in __init__
2023-04-27 13:06:28,679 ! raise InvalidRequirement(str(e)) from e
2023-04-27 13:06:28,679 ! wheel.vendored.packaging.requirements.InvalidRequirement: Expected end or semicolon (after version specifier)
2023-04-27 13:06:28,680 ! pillow>=6.2.0<7.0.0
2023-04-27 13:06:28,680 ! ~~~~~~~^
2023-04-27 13:06:28,680 ! [end of output]
2023-04-27 13:06:28,681 !
2023-04-27 13:06:28,681 ! note: This error originates from a subprocess, and is likely not a problem with pip.
2023-04-27 13:06:28,681 ! ERROR: Failed building wheel for OctoPrint-SpoolManager
2023-04-27 13:06:31,125 ! ERROR: Could not build wheels for OctoPrint-SpoolManager, which is required to install pyproject.toml-based projects
2023-04-27 13:06:31,628 > Failed to build OctoPrint-SpoolManager

—————

HTXF-g commented 1 year ago

this will fix #324

jattie-ire commented 1 year ago

I can confirm this fix, I have tested the installer on Linux from here and it works, however I initially ran into this isssue:

Initializing settings & plugin subsystem... Error loading plugin SpoolManager Traceback (most recent call last): File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint/plugin/core.py", line 1274, in _import_plugin module = _load_module(module_name, spec) File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint/plugin/core.py", line 52, in _load_module return imp.load_module(name, f, filename, details) File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint/vendor/imp.py", line 238, in load_module return load_package(name, filename) File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint/vendor/imp.py", line 212, in load_package return _load(spec) File "", line 711, in _load File "", line 680, in _load_unlocked File "", line 850, in exec_module File "", line 228, in _call_with_frames_removed File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint_SpoolManager/init.py", line 12, in from octoprint_SpoolManager.DatabaseManager import DatabaseManager File "/home/octo/OctoPrint/venv/lib/python3.9/site-packages/octoprint_SpoolManager/DatabaseManager.py", line 12, in from peewee import * ModuleNotFoundError: No module named 'peewee'

Should this be covered in the installer code as a dependency?

I had to pip install peewee and qrcode to resolve the issues.

HTXF-g commented 1 year ago

requirements.txt says "...Requirements can be found in setup.py..." I think that's enough.

kbrint commented 1 year ago

This looks like an awfully simple fix. @OllisGit please pull this PR!