OllisGit / OctoPrint-SpoolManager

Plugin for managing Spools
169 stars 59 forks source link

BUG: When Scanning QR Code of different spools, only spool 1 is selected for printing #329

Closed ScottGibb closed 5 months ago

ScottGibb commented 1 year ago

Issue

When using the plugin, I found that no matter which spool QR Code I scanned, the plugin would always select spool 1 in the database for printing. I'm running an iPhone 13 with the built-in QR Code Scanner, opening the webpage in Safari. When I scanned spool 2 in the database through the UI, the following link was created:

_http://wanhaoprint.local/login/?redirect=%2F%3F&permissions=STATUS%2CSETTINGS_READ#tab_plugin_SpoolManager-spoolId2_

It would seem that the URL is being created correctly, however possibly not being handled on the other side correctly.

A part of this, awesome plugin!!! Really enjoy using it, and looking forward to getting it integrated with my Label Maker!! (#325)

Steps to Repeat

Ticket #185 says this was fixed in V1.5, in my system i'm running V1.7.

Hardware/Software Setup

normen commented 1 year ago

Same here when using the direct link like http://octopi/plugin/SpoolManager/selectSpoolByQRCode/6

Edit: Add to that when displaying the QR code it always shows the name of the first spool as well, even though it shows different ID's

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

normen commented 1 year ago

bump

github-actions[bot] commented 1 year ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

normen commented 1 year ago

Meep

github-actions[bot] commented 11 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

ScottGibb commented 11 months ago

moop

mdziekon commented 11 months ago

This issue most likely has been already fixed in my fork of the plugin, see: https://github.com/mdziekon/OctoPrint-SpoolManager/issues/37

ScottGibb commented 11 months ago

@mdziekon Awesome, il give it a shot this weekend hopefully. Is there anyway to keep my database for spools intact when uninstalling this plugin and then installing yours?

mdziekon commented 11 months ago

@ScottGibb when using either URL or ZIP install, my fork should simply replace your installed original plugin, without affecting the DB. To be safe, make sure to perform a DB backup though.

ScottGibb commented 10 months ago

@mdziekon Sorry for taking so long to test it, but I've now installed your plugin, and tried both 1.8 and 2.0 and both do not work, The same issue as before keeps happening. When you scan the QR code it creates the correct URL as before, however, it continues to select the first spool in the database.

github-actions[bot] commented 9 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

normen commented 9 months ago

huargh

github-actions[bot] commented 8 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

ScottGibb commented 8 months ago

beep

github-actions[bot] commented 7 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

ScottGibb commented 7 months ago

bump

normen commented 7 months ago

I switched to this branch, seems to have all the fixes we need: https://github.com/jkotowicz1/OctoPrint-SpoolManager

Its settings are compatible, you just need to uninstall this version and install that version above using the .tar.gz file

Edit: Fixed link

ScottGibb commented 7 months ago

@normen Cheers for the link, sadly that repo also has the same issue as this. I'm gonna copy and paste the issue into that repo and see what happens

normen commented 7 months ago

@normen Cheers for the link, sadly that repo also has the same issue as this. I'm gonna copy and paste the issue into that repo and see what happens

Sorry, I gave the wrong link, this is the version I have installed (so many forks!) https://github.com/mdziekon/OctoPrint-SpoolManager

ScottGibb commented 7 months ago

@normen Just installed the Spool Manager from mdziekon. Still seem to be getting the same issue. I installed it using the zip location link https://github.com/mdziekon/OctoPrint-SpoolManager/releases/latest/download/master.zip Which then looks like this: image

But still seem to be getting the same functionality. Any ideas? You mentioned using the tar.gz, how did you go about installing it through that?

ScottGibb commented 7 months ago

@normen Ive created a new issue on the forked repository you added https://github.com/mdziekon/OctoPrint-SpoolManager/issues/52

normen commented 7 months ago

Omg, could it be this one? It has the links to the mdziedkon one so it looks like that in the settings for me too.. 😕

https://github.com/jkotowicz1/OctoPrint-SpoolManager

ScottGibb commented 7 months ago

@normen YESSSS!!!! That is the one that works, so so many forks hahah. For anyone that comes across this issue: This is the fork you want to use: https://github.com/jkotowicz1/OctoPrint-SpoolManager

Also special thanks to @normen for finding a fork in which the QR code scanning works!!

IMPORTANT: The repo linked above uses an old install link in the readme. Instead, go directly to releases and download the release manually. Then install this zip by uploading to octoprint over the LAN

ScottGibb commented 7 months ago

@normen, the other repository that @mdziekon made also has the bug fix with more features. If your interested, here is the issue discussion, where mdizekon helps me fix the qr bug, needed to checkout the prerelease code. https://github.com/mdziekon/OctoPrint-SpoolManager/issues/52

github-actions[bot] commented 6 months ago

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

github-actions[bot] commented 5 months ago

This issue was closed, because it has been already marked for 10 days with no activity.