search

OllyNural / NodeLeagueProject

League of Legends Project using Node.js and Angular.js
0 stars 0 forks source link

A couple of suggestions. #1

Open Lalien opened 8 years ago

Lalien commented 8 years ago

Just a friendly person passing by,

I took a look at your code and I'm wondering why you're not letting Angular's UI Router handle the serving of the HTML files instead of Node.js? And just leave the Node's routing to API calls?

If you want me to implement this then I'd be happy to. But I wasn't sure how tight the ship was.

And I thought the build was broken when I first launched it but it turned out that there was no route for the root. So you're met with a "Cannot GET /" error.

I hope this helps at all! :)

OllyNural commented 8 years ago

Hey! I'll be around later to look at the code in a few hours, but I've not used angular js much before so if you want to make the change go for it! Never had anyone comment on these things before so thanks :) did it work okay? I'm still working on getting the people's names through web scraping so at the moment the names are hard coded in the file