search

OlukaDenis / Justice-App

A justice app that will allow users to access justice in respective countries.
MIT License
2 stars 1 forks source link

Authentication - Google and Email Signin #2

Open OlukaDenis opened 5 years ago

OlukaDenis commented 5 years ago

Hello team, This issue specifically deals with the following;

This will also commerce ASAP, we shall just use the typical screen (common buttons or textviews) as we wait for the other group who is working on the login screens. The main task will be on the Java activities then connect to the firebase API. I have created a branch named google-email-signin so you'll pull this branch to your local repo and then push all the progress there then later we shall delete it.

Due date: 29th-August-2019

Hope to see progress soon

Denis Android Project Lead.

VICTORRELOADED commented 5 years ago

What is the time frame

On Fri, Aug 16, 2019, 15:21 Oluka Denis notifications@github.com wrote:

Assigned #2 https://github.com/OlukaDenis/Justice-App/issues/2 to @VICTORRELOADED https://github.com/VICTORRELOADED.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OlukaDenis/Justice-App/issues/2?email_source=notifications&email_token=AIPTOYFYGFYIWV2K2NCJOQ3QE2LTHA5CNFSM4IMG64Y2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTC3UWXY#event-2562149215, or mute the thread https://github.com/notifications/unsubscribe-auth/AIPTOYCBQSO7ZJ7PVA4DIXDQE2LTHANCNFSM4IMG64YQ .

OlukaDenis commented 5 years ago

This should be done within two weeks

joshmpaka commented 5 years ago

Are we going to use the default firebase-ui or a custom sign in screen

OlukaDenis commented 5 years ago

We should use a custom one so that we have control over it. In case of any exception, we'll be able to trace it. Thanks

joshmpaka commented 5 years ago

I believe all requirements for this issue have been met

OlukaDenis commented 5 years ago

I will have to merge changes for both branches together then we shall be able to mark these issues closed

joshmpaka commented 5 years ago

Ok, Boss

OlukaDenis commented 5 years ago

Hey @Josh-M-Dev , am in the process of merging the two branches but i have realised your code doesn't have the google-services.json file. It is missing.

joshmpaka commented 5 years ago

Yes. i thought you would create a firebase account and then just copy the google json file but if you need it i can upload it

OlukaDenis commented 5 years ago

Actually i had to create it: justice2019.app@gmail.com Password: Justice2019

We shall need those credentials throughout the development. I went on to connect the app to the Firebase account

joshmpaka commented 5 years ago

Noted

joshmpaka commented 5 years ago

@OlukaDenis I noticed you have enabled Phone verification. have you added that functionality or it was also required and hasnt been added yet.

OlukaDenis commented 5 years ago

Yeah it hasn't been added but we'll, lemme first get done with merging the two into one

joshmpaka commented 5 years ago

Ok

joshmpaka commented 5 years ago

@OlukaDenis Hello, i added the google json file for justice app to the project but the google sign in generated an error api exception 10. I did some digging and found out the most probable reason its not working is because of the SHA1 key provided(its a release key instead of debug key). Plus i also noticed the SHA1 key in your Travelmantics project is different from the one in the justice app. if you used the same computer for both projects then i think you might have provided a release key instead of debug key for the justice app.

OlukaDenis commented 5 years ago

You checkout the denis branch, i merged all the branches into one. It is working perfectly

Bryanmuloni commented 5 years ago

@OlukaDenis this is great, is it okay to pull from this branch? Besides, when is the next sprint starting we really do not have enough time remaining. Thank you