Peer2Peer_CodeReview-12/17/2021 - Githubissues

Omar-Muhamad / Leaderboard

This is a Webpack Project Leaderboard and uses API to add your game score and see a list of the other scores.

11 stars 0 forks source link

Peer2Peer_CodeReview-12/17/2021 #4

Open TheLuisAbarca opened 2 years ago

TheLuisAbarca commented 2 years ago

Hi @Omar-Muhamad you do an amazing job with your project. It looks cool, therefore the is always room to improve our project.

Here is a little list of what can be improved:

[ ] You have to avoid every time that is possible, using "hardcoded HTML" in javascript files, instead, you can use a specific js file with the HTML and export it, or you can make the approach of creating the HTML element manipulating the virtual dom using pure javascript.

https://github.com/Omar-Muhamad/Leaderboard/blob/685f19baf22facac0d160a2617acd84a1821f12d/src/utils.js#L23-L28

[ ] You can also clear the input fields of score and name after you submit an item to the API.
[ ] It would be a great idea to also implement the order of data fetched, because is a leaderboard, so logically people want to know who are the players that have the highest scores.

Omar-Muhamad commented 2 years ago

Thanks for the feedback I'll consider these changes