Add custom line endings.

OmarSkalli / fixy

Library for generating fixed width documents

MIT License

100 stars 45 forks source link

Add custom line endings. #13

Closed dan-jensen closed 9 years ago

dan-jensen commented 9 years ago

Added a way to apply custom line endings when calling "generate" on a document. This is most useful for applying Windows \r\n endings. Also added tests for this functionality.

OmarSkalli commented 9 years ago

@dan-jensen Thanks for submitting this PR, and apologies for not seeing it earlier. It looks good, just a few small suggestions to consider.

dan-jensen commented 9 years ago

@Chetane And I just saw your suggestions after you mentioned me when you merged samkim's PR. (I'm not sure why notifications weren't working for either of us.) It looks like samkin's PR does a nice job with line endings, so I'm closing my PR. Thanks for your good work.