V3 Beta Issues - Githubissues

tidusjar commented 7 years ago

[x] Allow user to pass in a directory where we store the database and logs
[x] reverse proxies do not work. Think it's to do with Angulars Base element. #df1ab01 (NEEDS TESTING)
[x] Something is null -here:https://github.com/tidusjar/Ombi/blob/DotNetCore/src/Ombi/Controllers/External/PlexController.cs#L55
[x] at Ombi.Schedule.Jobs.Plex.PlexUserImporter.d__6.MoveNext() in C:\projects\requestplex\src\Ombi.Schedule\Jobs\Plex\PlexUserImporter.cs:line 81 2017-10-01 07:01:22.062 +00:00 [Error] Connection id ""0HL88J5VQTL4M"", Request id ""0HL88J5VQTL4M:0000000A"": An unhandled exception was thrown by the application. System.NullReferenceException: Object reference not set to an instance of an object.

ydkmlt84 commented 7 years ago

I am on Ubuntu 16.04 and these are the issues that I have noticed:

[x] Login page doesn't show the custom logo very well.
[x] My servers are online but Landing Page shows 1 of 4 offline. I only have one Emby server.
[x] Settings-> User Management page is blank.
[x] Pushover test notification pop up doesn't show the correct verbage.
[ ] Possible issue with auto updater not working when Ombi ran as a service.
~~Did not receive a notification when an episode is requested...even as a non ADMIN user. it shows pending approval after hitting the request button.~~ This was user error.
[x] Admin does not receive a Pushover notification upon a request submission but I do receive an email notification. Pushover test notification works during setup.
[x] Selecting the episodes individually is not very clear. Should not show as pending approval, before submit request button is clicked and the request is actually submitted.
[x] Added: Remove or Deny options do not work in the requests page of a TVShow.
[x] TV Show availability is not working with Emby. I am not sure of Plex.
[x] Can not edit the Media Server settings once they are initially set. Must remove the server and add a new.
[x] When a TV show has every episode available, the request button should only say available. The request button shouldn't even be there for that show.
Reverse proxy settings (webroot switch) adds a folder with the webroot name that is set. Which by the way cannot be Ombi because there is already a file named Ombi. Even though it should be a directory it won't create it because of that. Anyways, the folder that gets created has another folder in it with the name wwwroot. However, that folder is empty. I tried to symlink to the main wwwroot folder which got me to the main UI but there was no search option. If you need more info please let me know. Use the Base URL on the Ombi Settings
[x] The way the TV episodes are now selected is much more clear but...if possible once the Submit Request button is clicked, can they then say pending approval/processing request/etc. ?
[X] The custom logo is much better now.
[x] The about page is very nice but should be on the far right of the settings menu. On the right side of the system dropdown.
[ ] Possibly make the date format in TV Show episodes "Air Date" to be Month/Day/Year? (i.e. 04/28/17)
[x] The synopsis for a TV Show doesn't wrap to be able to read it all.
[x] Is it possible to add the Network a show is on on the search page?
[x] TVShows don't show pending approval when requested by a non admin user.
~~Is it possible to show a bubble notification on the requests tab to show the number of pending requests?~~
[x] This show does not allow you to request it. There are a few others as well, and they dont have thumbnails. They are listed in the "Most Anticipated Shows" suggestion. http://www.imdb.com/title/tt6053538/
[x] Run importer button under Configuration->User Management starts the Plex user importer but I have Emby. Manually started EmbyUserImporter and it worked.
[x] Custom logo images are not correct on password reset screens.

AmansRevenger commented 7 years ago

[x] (Test) non-admin users approved requests dont seem to get forwarded to Sonarr/Radarr
[x] On the Requests page , clicking one of the headers Movies/TV Shows switches the page content, but not the header

will add as I see more, okay?

[x] Custom Logo (Preview? )doesnt work, neither relative path nor absolute path, maybe clarifying tooltip how to address
[x] System --> Update always says Update available when checking
[x] no favicon

Majawat commented 7 years ago

On Windows 10, some issues and thoughts I've noticed:

Issues - Something broken

[x] After approving a list of TV Show Episodes, it shows Processing Request. After refreshing the page, they show Pending Approval with the Approve link even though it did hand it to Sonarr.
[x] A user requested latest season of Greys Anatomy which has 4 total episodes listed, 2 released, 2 future. After approval, Ombi sent only the 2 future to be monitored by Sonarr, not the 2 released already.
[x] Entering in an Application URL in Customization and hitting Submit says it saved, but refreshing the page and the text in the box disappears.
[x] Admin email notification is setup and working, but clicking on Send Welcome Email on a user, no email is sent, no notification is displayed. I assume this is a coming feature.
[x] Gmail SMTP requires an "insecure app password" (https://support.google.com/accounts/answer/185833?hl=en) when using Google two-factor authentication. However, when inputting the account password and not the "app password", Ombi says that the password is correct (it's not). Not sure how this could be handled in Ombi, or just a wiki page with a pointer to Google's documentation.
[x] Deny with a Reason button doesn't work, Deny does though.
~~The Send Reset Password Link uses "http://localhost" as the url domain. | known behavior, maybe document for Admins~~
[x] Request posters have wrong link to tmdb.org. Example: <img alt="poster" class="img-responsive poster" src="https://image.tmdb.org/t/p/w150/https://image.tmdb.org/t/p/w300/https://image.tmdb.org/t/p/w300//w23awyrZNZSiGy7F4KrmV5aMfbl.jpg"> Cannot Reproduce - TidusJar

UI Tweaks - Typos, small visual changes

[ ] Show Current version and available update version on Update Settings to compare.
[ ] Show status of update process on Update Settings page (downloading, installing, restarting, etc.)
[x] Pushbullet Settings page, the link to pushbullet website should open in a new tab/window.
[x] Settings icon always shows Update Available!
[x] When testing Pushbullet during setup, the notification popup says "check the discord channel" instead of "pushbullet". I don't have the other systems to check theirs.
[x] Deny drop down on Requests page is extra large. See https://i.imgur.com/x7bawvv.png
[x] Report Issue drop down on Requests page shows incorrect text. See https://i.imgur.com/x7bawvv.png

Suggestions - Ways to improve user experience

[x] Application Name field in Customization should have a tooltip that states "Requires application restart", as should anything else that should.
[x] Favicon should be on transparent background
[x] User roles are not defined. Most are self explanatory, but what does Power User give? See here - TidusJar
[x] Just verifying, users will have their own Ombi passwords and not authenticate through Plex? If that's the case, it should be noted somewhere within Ombi at least for the Admin to let users know, but best if for users at logon. I could assume this will be noted in the Welcome email.

Missing Feature - Features present in V2 but not in V3. I assume these will be added later

[ ] Users can see all other requests.
[ ] Users cannot request a movie after someone else has. In theory this would mean that the second, third, etc. users would not get notified once the movie is available.
[ ] No rate limiting on requests. Please make the time variable: for example, I would like to limit to 7 Movie requests per week, and 1 TV Show per 2 weeks.
[ ] No ability to filter views on Requests.

Feature Request - Features I've always wanted

[ ] Natively allow to run as a service instead of relying on external services such as NSSM or manually configured.
[ ] Unable to edit Issue reasons. (the default ones have never met my needs so I instruct all my users to choose Other)
[ ] Ability to archive completed requests instead of remove. Keeps the Requests page clean, but keeps the history for users. At least filter out Available media by default
[ ] Have a link to quick Approve or Deny from the Request notification (email/Pushbullet/etc).
[ ] A way to customize the external server address, making notification links to Ombi usable regardless of click/send source.

I'll add more as I come across them.

Jose-Linares commented 7 years ago

[x] Allow imported users to login.

jonathanfinley commented 7 years ago

[x] notification that your not on the latest version (Similar to v2's banner)

Magikarplvl4 commented 7 years ago

Beaware, the reported function is not finished yet. @tidusjar already does know that :)

tidusjar commented 7 years ago

@Auwen

Application Name field in Customization should have a tooltip that states "Requires application restart", as should anything else that should.

It doesn't need a restart, just need to refresh the page

User roles are not defined. Most are self explanatory, but what does Power User give?

There will be a button on all the settings pages to take you to a wiki entry on Github that will explain all of this.

Just verifying, users will have their own Ombi passwords and not authenticate through Plex? If that's the case, it should be noted somewhere within Ombi at least for the Admin to let users know, but best if for users at logon. I could assume this will be noted in the Welcome email.

If they have been imported into Ombi from Plex/Emby then they will authenticate through Plex/Emby and they do not have a password on Ombi. (The authentication through 3rd party is not done yet)

Majawat commented 7 years ago

It doesn't need a restart, just need to refresh the page

Hmm, could have sworn I did that. Maybe my browser was caching, or probably just crazy. I'll believe you and close.

button on all settings pages to take to a wiki entry

Perfect!

The authentication through 3rd party is not done yet

Ah! That makes sense on why my test user was having issues.

Magikarplvl4 commented 7 years ago

[x] Delete button in User Management isn't working (when you try to delete a user) - Cannot Reproduce - TidusJar

Magikarplvl4 commented 7 years ago

[x] Found a critical bug in the user import job for plex, we need to support also special characters and spaces in usernames

Console output:

warn: Microsoft.AspNetCore.Identity.UserManager[13]
      User 9b3c7ac7-5912-4551-b8fc-c54ae7433d35 validation failed: InvalidUserName.
fail: Ombi.Schedule.Jobs.Plex.PlexUserImporter[2003]
      User name 'XX XX XX' is invalid, can only contain letters or digits.

[x] if a movie/tv show is requested in a backend system like sonarr/radarr but not in ombi the system will show 2 different tags: Processing Request and Not Requested instead of only Processing Request
[x] style difference between requesting a movie and a tv show. (title is white instead of orange, image on the left is smaller and the text is smaller)

~~Run OmbiAutomaticUpdater.Update every 24 hours instead of every 2 hours~~ - It's already setup to run Daily - TidusJar
[x] Allow Plex/Emby users to login only with there username

jonathanfinley commented 7 years ago

Unable to trigger the update nor does the auto update seem to want to run.

here is the output of the error:

Failed
An exception occurred during performance of the job.
System.IO.InvalidDataException

End of Central Directory record could not be found.

System.IO.InvalidDataException: End of Central Directory record could not be found.
   at System.IO.Compression.ZipArchive.ReadEndOfCentralDirectory()
   at System.IO.Compression.ZipArchive.Init(Stream stream, ZipArchiveMode mode, Boolean leaveOpen)
   at System.IO.Compression.ZipArchive..ctor(Stream stream, ZipArchiveMode mode, Boolean leaveOpen, Encoding entryNameEncoding)
   at System.IO.Compression.ZipFile.Open(String archiveFileName, ZipArchiveMode mode, Encoding entryNameEncoding)
   at Ombi.Schedule.Jobs.Ombi.OmbiAutomaticUpdater.<Update>d__16.MoveNext() in C:\projects\requestplex\src\Ombi.Schedule\Jobs\Ombi\OmbiAutomaticUpdater.cs:line 194

Undeadllama commented 7 years ago

Can confirm the reverse proxied image issue jonfinley posted above, seeing the same behaviour.

[ ] Background image on home screen should stretch-to-fit instead of tile on large monitors.

Magikarplvl4 commented 7 years ago

@Brentnall27 @jonfinley can you please use the issue format? - [ ] Short issue description

Magikarplvl4 commented 7 years ago

[x] plex users can't login with there e-mail adres instead of the username. (i was trying to make a workaround to at the e-mail adres like a Alias, also that didn't work :( )
[x] mouse cursor is changes when you click something in the request dropdown button
[x] Request all seasons for a tv show is not sending to sonarr

FalafelMuncher69 commented 7 years ago

[x] Discord notifications produce error:

Failed to send Discord Notification
System.InvalidOperationException: Misused header name. Make sure request headers are used with HttpRequestMessage, response headers with HttpResponseMessage, and content headers with HttpContent objects.

tidusjar commented 7 years ago

@jonfinley Looks like the .gz file was malformed, does this keep happening for you?

LettuceSnob commented 7 years ago

[x] Using "run importer" under User Management Settings with "Import Plex Users" selected does not work. No errors in Ombi log, but browser console points to a query of localhost:5000/request/api/v1/Emby/users despite not having an Emby server added to Ombi

Magikarplvl4 commented 7 years ago

@LettuceSnob did you check after hitting run importer button the tab usermanagement ?

LettuceSnob commented 7 years ago

@PotatoQuality Yes, I checked. No plex users were there.

jscottdouglas commented 7 years ago

Anyone get this to work as a service systemd?

LettuceSnob commented 7 years ago

@jscottdouglas yea

[Unit]
Description=Ombi
After=syslog.target network.target

[Service]
User=name
Group=name
Type=simple
WorkingDirectory=/opt/Ombi/
ExecStart=/opt/Ombi/Ombi
TimeoutStopSec=20
KillMode=process
Restart=on-failure

[Install]
WantedBy=multi-user.target

AcidRain999 commented 7 years ago

segmentation fault comes up whenever i run the program and browse to it from chrome on windows

"Segmentation fault" is all i get back from the program. it is running on debian.

Magikarplvl4 commented 7 years ago

@AcidRain999 can you provide use the whole error in the error log?

its in ./logs

AcidRain999 commented 7 years ago

i looked all over the Ombi directory and there is no logs folder or file called logs

LettuceSnob commented 7 years ago

@AcidRain999 I had the same problem earlier, but then it randomly appeared the next day. I suspect that the directory only creates itself the first time a log worthy event occurs, and then when it needs to write to a file, a path is created.

tidusjar commented 7 years ago

@AcidRain999 Please post a screenshot of the full error

shawpe commented 7 years ago

V3 email notifications (not tested others). shows as changing format of notification, but doesn't actually send email with those changes.

untitled

jonathanfinley commented 7 years ago

Looks like the .gz file was malformed, does this keep happening for you? @tidusjar

So I just tried running the auto update. The only output I see in hangfire +2ms . Starting the updater nothing else. this was a manually triggered update via the webui.

AcidRain999 commented 7 years ago

@tidusjar

untitled

that is all i get, and that is just from going to the website and waiting for it to load, the page will load but the program crashes after that

tidusjar commented 7 years ago

@AcidRain999 take a look at this: https://github.com/dotnet/core/issues/649

verttex commented 7 years ago

@jonfinley @tidusjar Getting the same error for the updater.

warn: Hangfire.AutomaticRetryAttribute[0] Failed to process the job '1e766c7c-8b57-4f3b-9633-b2c71256dd1a': an exception occurred. Retry attempt 1 of 10 will be performed in 00:00:29. System.IO.InvalidDataException: End of Central Directory record could not be found. at System.IO.Compression.ZipArchive.ReadEndOfCentralDirectory() at System.IO.Compression.ZipArchive.Init(Stream stream, ZipArchiveMode mode, Boolean leaveOpen) at System.IO.Compression.ZipArchive..ctor(Stream stream, ZipArchiveMode mode, Boolean leaveOpen, E ncoding entryNameEncoding) at System.IO.Compression.ZipFile.Open(String archiveFileName, ZipArchiveMode mode, Encoding entryN ameEncoding) at Ombi.Schedule.Jobs.Ombi.OmbiAutomaticUpdater.d__16.MoveNext() in C:\projects\requestple x\src\Ombi.Schedule\Jobs\Ombi\OmbiAutomaticUpdater.cs:line 194

scottocs11 commented 7 years ago

I just tried out Ombi 3 on Windows, and I can get it to connect to Sonarr and Radarr, but I can't manage to get it to actually add movies. This is what I get when I try to add a movie.

Sometimes, I get this:

2017-10-02 19:38:56.622 -04:00 [Error] StatusCode: BadRequest, Reason: Bad Request
2017-10-02 19:38:56.639 -04:00 [Error] 'Profile Id' must be greater than '0'.
2017-10-02 19:38:56.642 -04:00 [Warning] Tried auto sending movie but failed. Message: "'Profile Id' must be greater than '0'."

goldenpipes commented 7 years ago

[x] Hello! I tried setting up Discord notifications. I added the {PosterImage} tag to get pictures showing up but it seems there is an error in the markup. The URL i got has an extra "/" in it. Im not sure if its pulling it from https://image.tmdb.org that way or if its being generated oddly. here is the URL i got https://image.tmdb.org/t/p/w300//l2LObt7s0hakFi9ga6tOKMqKkuo.jpg

here is the url I expected (which loads in discord.) https://image.tmdb.org/t/p/w300/l2LObt7s0hakFi9ga6tOKMqKkuo.jpg

sorry if i am doing this wrong i am new to github!

AcidRain999 commented 7 years ago

well if anyone else has the issue with segmentation fault on debian i was able to get it to work so far by using this command.

apt-get install libcurl3=7.38.0-4+deb8u5 libcurl4-openssl-dev=7.38.0-4+deb8u5

Nashable commented 7 years ago

Another report on a fresh windows install with the Radarr issue Scott reported. https://github.com/tidusjar/Ombi/issues/1513#issuecomment-333695703

2017-10-02 19:38:56.622 -04:00 [Error] StatusCode: BadRequest, Reason: Bad Request 2017-10-02 19:38:56.639 -04:00 [Error] 'Profile Id' must be greater than '0'. 2017-10-02 19:38:56.642 -04:00 [Warning] Tried auto sending movie but failed. Message: "'Profile Id' must be greater than '0'."

I have profiles selected and API key has been verified. Sonarr seems to be working fine importing requests.

Key	Value
Version	3.0.2073
Branch	DotNetCore
OS Architecture	X64
OS Description	Microsoft Windows 10.0.15063
Process Architecture	X64

tidusjar commented 7 years ago

The Radarr issue must be from my latest changes... I'll get it fixed

dirtycajunrice commented 7 years ago

[x] As of the latest release No one can request a show. not even the original admin. Popup reply is: show added: 'Profile Id' must be greater than '0'.

tidusjar commented 7 years ago

Upgrade to 3.0.2075 and this has been fixed @DirtyCajunRice

Magikarplvl4 commented 7 years ago

@DirtyCajunRice that is already fixed https://github.com/tidusjar/Ombi/commit/43a78f0e3cbb02559e63902530e54c0b3690da05

dirtycajunrice commented 7 years ago

Yep. Tested. Must have downloaded 5 minutes before the fix. Yall are fast!

tidusjar commented 7 years ago

@shawpe So I had a look if I could convert the newlines into <br />'s and that would work fine, but the issue would be that it would also apply to other notifications that may not support HTML.

So i'm not going to fix this, What I suggest you do is input HTML into that field to format HTML notifications.

Codehhh commented 7 years ago

[x] Requesting TV sets each episode to wanted, but not the season
[ ] View Request doesn't default season number for selection

~~- [ ] Test Connectivity for Plex gives an error growl - "We could not connect to the Plex server {my server name here}!", but I can Load Libraries and import users~~ My reverse proxy wasn't allowing API calls, resorted to connecting directly to plex port

[ ] (i) in Email Notifications is not user friendly, it goes off the screen and loads a scrollbar that I can't use. - not sure what this means - TidusJar
[x] No "send test email"?

Sorry if these have been fixed already, I'm using the docker from LSIO and am still on v3.0.2073

Magikarplvl4 commented 7 years ago

@Codehhh edit: My mistake, you are up to date!

Codehhh commented 7 years ago

@PotatoQuality I think I updated during the post.

I'm now getting a massive stack trace in my log file. log-20171003.txt

If you need access to check my configuration I can make an account for you.

tidusjar commented 7 years ago

@Codehhh your radarr configuration is incorrect according to the log

Codehhh commented 7 years ago

@tidusjar Currently all I'm trying to do is import users from Plex. The job in Hangfire has been processing for 6 minutes with no users imported. I'm still getting the Radarr exception even with Radarr disabled and no settings filled in Edit: Just did a full clean pull and I was able to import all of my Plex users.

[ ] Configuring Radarr throws error if "Default Minimum Availability" hasn't been set but just trying to get Profiles and Base Path
[ ] Email Notifications "Test Connectivity" shows a success growl on failure
[ ] Email Notifications "Test Connectivity" shows "Settings Saves" growl (is it saving first?)
[ ] Movies Request -> Top Rated movies throws frontend error

Magikarplvl4 commented 7 years ago

~~don't show deny button when a request is auto approved~~

goldenpipes commented 7 years ago

[ ] clicking "approve request" on an item requested by Plex user with only RequestTv and RequestMovie permissions; as admin seems to do nothing. Green growl pops up and changes to approved, but on page refresh it's reverted back to "Request status: Pending Approval." Denying a request seems to work though!

@PotatoQuality when I deny a request, approve is still there as well. Is this expected behavior?

daymanbpi commented 7 years ago

[x] New Request Notification does not display Subject Line. Slack message only displays generic message. https://imgur.com/a/VvySH Generic https://imgur.com/a/bYVaQ

Codehhh commented 7 years ago

~~Updater fails -- Docker running on UnRaid~~

- I do not expect this to work for docker - TidusJar

Ombi-app / Ombi

V3 Beta Issues #1513