Ombi-app / Ombi

Want a Movie or TV Show on Plex/Emby/Jellyfin? Use Ombi!
http://ombi.io
GNU General Public License v2.0
3.7k stars 395 forks source link

Not receiving notifications via Pushover #2385

Closed jojogrosso closed 6 years ago

jojogrosso commented 6 years ago

Ombi build Version:

V 3.0.3421

Update Branch:

master

Media Sever:

Plex

Media Server Version:

1.13.4.5251

Operating System:

Windows Server 2016

Ombi Applicable Logs (from /logs/ directory or the Admin page):


2018-07-13 20:36:27.783 -04:00 [Debug] Searching : "test"
2018-07-13 20:36:27.807 -04:00 [Debug] Search Result: "Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult"
2018-07-13 20:36:29.011 -04:00 [Error] StatusCode: TooManyRequests, Reason: , RequestUri: http://api.themoviedb.org/3/movie/298027?api_key=b8eabaf5608b88d0298aa189dd90bf00
2018-07-13 20:36:29.027 -04:00 [Error] Retrying RequestUri: http://api.themoviedb.org/3/movie/298027?api_key=b8eabaf5608b88d0298aa189dd90bf00 Because we got Status Code: TooManyRequests
2018-07-13 20:36:31.401 -04:00 [Error] StatusCode: TooManyRequests, Reason: , RequestUri: http://api.themoviedb.org/3/movie/529564?api_key=b8eabaf5608b88d0298aa189dd90bf00&append_to_response=videos,release_dates
2018-07-13 20:36:31.415 -04:00 [Error] Retrying RequestUri: http://api.themoviedb.org/3/movie/529564?api_key=b8eabaf5608b88d0298aa189dd90bf00&append_to_response=videos,release_dates Because we got Status Code: TooManyRequests
2018-07-13 20:36:41.586 -04:00 [Warning] Tried auto sending movie but failed. Message: "(null)"
2018-07-13 20:46:15.989 -04:00 [Debug] Search Result: "Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult"
2018-07-13 20:46:18.282 -04:00 [Debug] Searching : "s"
2018-07-13 20:46:18.347 -04:00 [Debug] Search Result: "Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult"
2018-07-13 20:46:19.388 -04:00 [Error] StatusCode: TooManyRequests, Reason: , RequestUri: http://api.themoviedb.org/3/movie/651?api_key=b8eabaf5608b88d0298aa189dd90bf00
2018-07-13 20:46:19.403 -04:00 [Error] Retrying RequestUri: http://api.themoviedb.org/3/movie/651?api_key=b8eabaf5608b88d0298aa189dd90bf00 Because we got Status Code: TooManyRequests
2018-07-13 20:46:19.481 -04:00 [Debug] Searching : "spider"
2018-07-13 20:46:19.495 -04:00 [Error] StatusCode: TooManyRequests, Reason: , RequestUri: http://api.themoviedb.org/3/search/movie?api_key=b8eabaf5608b88d0298aa189dd90bf00&query=spider
2018-07-13 20:46:19.510 -04:00 [Error] Retrying RequestUri: http://api.themoviedb.org/3/search/movie?api_key=b8eabaf5608b88d0298aa189dd90bf00&query=spider Because we got Status Code: TooManyRequests
2018-07-13 20:46:25.690 -04:00 [Error] StatusCode: TooManyRequests, Reason: , RequestUri: http://api.themoviedb.org/3/movie/17532?api_key=b8eabaf5608b88d0298aa189dd90bf00&append_to_response=videos,release_dates
2018-07-13 20:46:25.705 -04:00 [Error] Retrying RequestUri: http://api.themoviedb.org/3/movie/17532?api_key=b8eabaf5608b88d0298aa189dd90bf00&append_to_response=videos,release_dates Because we got Status Code: TooManyRequests
2018-07-13 20:46:29.541 -04:00 [Debug] Search Result: "Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult, Ombi.Api.TheMovieDb.Models.MovieSearchResult"

Problem Description:

I stopped receiving "new request" notifications from Pushover about a month ago. When I "test" it, I get the test notification. I tried to disable it. Saved it, then re-enabled it, but I'm still not receiving them.

Reproduction Steps:

I used to receive notifications from Pushover when someone requested a movie.

SpartacusIam commented 6 years ago

+1 Having the same issue. Stopped working also about a month ago. Tests work.

anojht commented 6 years ago

could you remove any quotes, single or double from the notification templates and try again?

SpartacusIam commented 6 years ago

I removed all quotes, no luck. This is what my new request code looks like:

Hello! The user {RequestedUser} has requested the {Type} {Title}! Please log in to approve this request. Request Date: {RequestedDate}

anojht commented 6 years ago

I think the problem lies with certain notification variables. I see that you have made some changes to the template, can you try changing the template to the following for troubleshooting purposes: Hello! The user {UserName} has requested the {Type} {Title}!

SpartacusIam commented 6 years ago

Just tested this. No change.

jojogrosso commented 6 years ago

I haven’t changed mine. I believe it’s still default showing:

Hello! The user '{UserName}' has requested the {Type} '{Title}'! Please log in to approve this request. Request Date: {RequestedDate}

I just changed it to remove quotes, as requested, to show:

Hello! The user {UserName} has requested the {Type} {Title}! Please log in to approve this request. Request Date: {RequestedDate}

Still no luck.

anojht commented 6 years ago

@jojogrosso remove everything you have for the template and paste exactly this: Hello! The user {UserName} has requested the {Type} {Title}! and then try it please

jojogrosso commented 6 years ago

@anojht I just tried that, and I still didn't get a notification.

anojht commented 6 years ago

We had a similar issue before and that template setting fixed it. But it looks like this might be a different bug, thanks for trying it!

jojogrosso commented 6 years ago

No, problem. If you want me to try anything else, let me know. Thanks for working on this!

gold007eye commented 6 years ago

I am having the same issue, but with 1 difference. I am receiving the notifications, but anything variable content is mostly missing.

Example: Your Request of {Title} on {ApplicationName} is now available! Comes through as: Your request of on Plex Server

jojogrosso commented 6 years ago

Well, I just got a notification. Looks like my Ombi has been updated to 3.0.3477. Was there a fix for this in this version ?

tidusjar commented 6 years ago

Not as far as I am aware, so does this work?

rdavey228 commented 6 years ago

Doesnt work for me - I just updated.

I get "Request Accepted" notifications but the initial notification to say a user has requested an item never works.

Just updated to 3.0.3477

tidusjar commented 6 years ago

Can you please post any relevant logs

gold007eye commented 6 years ago

I'm not sure if this helps, but after updating to 3.0.3477 some messages are coming through ok, but others are still not filling in the variables. this is the only info i see in the log (this was after trying a fresh start of OMBI).

image

Could you possible list out the defaul notification messages here so that we can try and change them back to the default and see if the issue is still happening?

This notification comes through just fine: Hello! Your request for {Title} has been approved!`

This notification cuts out everything AFTER the {ApplicationName} variable: Your request of {Title} on {ApplicationName} is now available!

Update 2: Adding more information. I am doing some testing and noticed that maybe special characters are causing an issue (at least for comments put in issue location).

Example: Test Comment 3..!@# the '#' prevents anything after that from displaying in the notification. Maybe any special characters that can cause conflicts with code can be set as "Not Allowed". Will update with any further results.

Update 3: So another issue I have noticed is if the "Application Name" has an ' in it that causes issues and anything after the apostrophe doesn't show up in notifications.

Example: Tidusjar's Plex Server will just show up as "Tidusjar" in the notification.

tidusjar commented 6 years ago

Interesting, does your Application Name also contain special characters? it sounds like Pushover is truncating the text once it finds a special character

Can you check this and get back to me?

gold007eye commented 6 years ago

It was funny you asked this as I was just noticing that. I tried changing {ApplicationName} to '{ApplicationName}' but then nothing showed up for that variable.

With the example in my previous post if I remove the ' then it sends the notification correctly.

Example: Tidusjars Plex Server will show up as "Tidusjars Plex Server" in the notification.

gold007eye commented 6 years ago

So it does seem like certain special characters might be interfering with either the code output of notifications or just with pushover notifications.

Update 4: These special characters will cause issues with notifications:

& + ' < >

tidusjar commented 6 years ago

Nice work! I'll strip out these characters before sending to pushover!

tidusjar commented 6 years ago

Fixed in develop

jojogrosso commented 5 years ago

Hi, I hate to re-open this, but I am now on build 3.0.4680 with the same issue here. The tests work, but I don't get New Request notifications anymore. I don't have any special characters either.

Nabukodonosor commented 2 years ago

I'm on 4.10.2 and still don't get Pushover nothifications. Can't believe they still can't fix this. :/

tidusjar commented 2 years ago

Raise a new issue. This one is closed.

The codebase has completely changed in 3 years from this original issue.