search

Ombi-app / Ombi

Want a Movie or TV Show on Plex/Emby/Jellyfin? Use Ombi!
http://ombi.io
GNU General Public License v2.0
3.69k stars 395 forks source link

Plex oAuth Authentication Broken #3073

Closed jeffe closed 5 years ago

jeffe commented 5 years ago

Describe the bug Plex appears to have updated their API to enforce the requirement of a new header variable (X-Plex-Product:) It appears Ombi doesn't currently include this parameter, as a result auth attempts via plex oAuth are failing.

To Reproduce Attempt to login via Plex oAuth

Expected behavior You should login.

Screenshots n/a

Logs (Logs directory where Ombi is located) Log Output is: fail: Ombi.Api.Api[1000]

StatusCode: NotFound, Reason: Not Found, RequestUri: https://plex.tv/api/v2/pins/XXXXXXXXX

Desktop (please complete the following information): All Browsers, All Platforms

Ombi Version (please complete the following information): Version: Current Plex Version: Plex Pass Current

Additional context Discussion on Plex Forum: https://forums.plex.tv/t/plex-oauth-not-working-with-tautulli-ombi-etc/433945

ombi-bot commented 5 years ago

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://github.com/tidusjar/ombi/wiki/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

tidusjar commented 5 years ago

This is incorrect, Ombi does provide the X-Plex-Product parameter, and it sets it to Ombi.

Plex have recently changed how this works with their OAuth that is currently only allowing requests that Identify themself as Plex Web to authenticate.

jeffe commented 5 years ago

Ah, apologies, my mistake.

Is there any known information on if Plex will open the scope of allowed application identifiers again? Or is there an alternative solution (short of modifying the local instance to send a different client identifier)

tidusjar commented 5 years ago

People hope this is just a mistake on Plex's end and that it will be reverted. I'm not 100% sure if this wasn't their initial intention.

For now I'll make a change to let Ombi identify itself as the Plex Web Client to let us through. I'll push out a stable release in the next few hours.

jeffe commented 5 years ago

Thank you!