Ombi-app / Ombi

Want a Movie or TV Show on Plex/Emby/Jellyfin? Use Ombi!
http://ombi.io
GNU General Public License v2.0
3.71k stars 395 forks source link

V4 Poster aspect ratio keeps changing #4218

Closed mkanet closed 3 years ago

mkanet commented 3 years ago

Describe the bug Posters not displaying correctly. Aspect ratio of posters changes as the browser size changes. This causes posters to turn into square; cutting off the poster image. Posters should only shrink or grow without changing aspect ratio (when web browser is resized)

To Reproduce Steps to reproduce the behavior: Resize web browser size

Expected behavior Posters should only grow or shrink when resizing the web browser WITHOUT changing poster aspect ratio.

WRONG AR Screenshot 06-08-2021 at 01 54 40 PM

Poster aspect ratio should similar to below, regardless of how big/small the web browser size is. Only poster size should change, not aspect ratio:

CORRECT AR Screenshot 06-08-2021 at 01 56 35 PM

ombi-bot commented 3 years ago

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://docs.ombi.app/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

twanariens commented 3 years ago

A fix has been build, now waiting if the dev wants to accept the change

twanariens commented 3 years ago

That release does not include my PR code unfortunately. As you can see in the PR, the dev made some comments about my fix (mostly concerning mobile view issues) that I need to fix. Will probably do that tonight/tomorrow.

Op do 10 jun. 2021 om 18:40 schreef MKANET @.***>:

@twanariens https://github.com/twanariens thanks for all your hard work. I noticed that the PR was approved; and, that there is a new pre-release v4.0.1412 from yesterday here https://github.com/Ombi-app/Ombi.Releases/releases. Does that release include your latest PR code? I tried it just now, but posters still don't maintain their AR. If I need a special developer build, could you point me to where I can download it from?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ombi-app/Ombi/issues/4218#issuecomment-858774917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJ3CTFXW4SML2AUFAJHT6DTSDTGLANCNFSM46KXJVWA .

mkanet commented 3 years ago

That release does not include my PR code unfortunately. As you can see in the PR, the dev made some comments about my fix (mostly concerning mobile view issues) that I need to fix. Will probably do that tonight/tomorrow. Op do 10 jun. 2021 om 18:40 schreef MKANET @.***>:

Thanks for explaining. BTW: A related note to the dev's comments...

I noticed that Ombi in general seems not to use space very effectively on smaller display areas such as mobile or even a PC desktop web browser in respect to similar web interfaces (Radarr, Sonarr, Petio, Overseer). Ombi can barely fit 4 posters on a mobile screen (even without the extra-large sidebar). Maybe, you could look into resizing items on the layout to fit posters more efficiently in general? Even on my PC desktop web browser, the layout wastes a lot of valuable real estate.

Ombi: Ombi-640

Petio: petio-640

Radarr: Radarr-640