Ombi-app / Ombi

Want a Movie or TV Show on Plex/Emby/Jellyfin? Use Ombi!
http://ombi.io
GNU General Public License v2.0
3.69k stars 395 forks source link

Empty Image email notification #891

Closed rulles closed 7 years ago

rulles commented 7 years ago

Ombi Version:

V 2.0.1186 (EAP)

Update Branch:

Early Access Preview

Operating System:

CentOS 7

Mono Version (only if your not on windows)

4.2.4

Problem Description:

Hello, I realized a problem/bug. When some user do some request and i add the item in plex server and the email notification goes with empty image of the content.

The url for image on email is something like

https://ci5.googleusercontent.com/proxy/jx3iqPDPNrffe984Ojmcqaq_pK3ecqmC4Bz_uNr0hJUCJ3jwDZlUw8VnbWCQWv2AS9OLa4YFi4FIXZ7M_A=s0-d-e1-ft#http:///zfpv5xETXC1LvVNzRSAQQ8knL6O.jpg

Don't show nothing.

Reproduction Steps:

Do some request, add item, wait or force cronjob so send email notifications.

Ombi-robot commented 7 years ago

Hi! Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format. Before posting make sure you also read our FAQ and known issues. Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful. If we need more information or there is some progress we tag the issue or update the tag and keep you updated. Cheers! Ombi Support Team

tidusjar commented 7 years ago

This is the notification to tell the admin that someone has requested something?

What was requested?

On Thu, 5 Jan 2017, 10:20 am Ombi Support, notifications@github.com wrote:

Hi! Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format. Before posting make sure you also read our FAQ https://github.com/tidusjar/Ombi/wiki/FAQ and known issues https://github.com/tidusjar/Ombi/wiki/Known-Issues. Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful. If we need more information or there is some progress we tag the issue or update the tag and keep you updated. Cheers! Ombi Support Team

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-270610915, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVaLHOl2TgXxuvaUFbmEZfxHRF7m-Vcks5rPMPZgaJpZM4Lbier .

rulles commented 7 years ago

No, is the notification tell the user that content they are request is available.

Atenciosamente/ With best Regards, António Pinto

2017-01-05 11:28 GMT+00:00 Jamie notifications@github.com:

This is the notification to tell the admin that someone has requested something?

What was requested?

On Thu, 5 Jan 2017, 10:20 am Ombi Support, notifications@github.com wrote:

Hi! Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format. Before posting make sure you also read our FAQ https://github.com/tidusjar/Ombi/wiki/FAQ and known issues https://github.com/tidusjar/Ombi/wiki/Known-Issues. Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful. If we need more information or there is some progress we tag the issue or update the tag and keep you updated. Cheers! Ombi Support Team

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-270610915, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGVaLHOl2TgXxuvaUFbmEZfxHRF7m-Vcks5rPMPZgaJpZM4Lbier .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-270623621, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9Zh53cmbZfb47P0MDQFCmOfzb_WN4ks5rPNP0gaJpZM4Lbier .

tidusjar commented 7 years ago

What was the request that became 'available' it's possible that the API results are missing the image. Or is this happening on everyyhing?

rulles commented 7 years ago

This happening on on every content in section movies. Because the section tv-shows not send notifications emails when they are added.

Atenciosamente/ With best Regards, António Pinto

2017-01-05 14:28 GMT+00:00 Jamie notifications@github.com:

What was the request that became 'available' it's possible that the API results are missing the image. Or is this happening on everyyhing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-270656182, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZpuCI266ZyVPXA1GOAxG8hljxgjEks5rPP4XgaJpZM4Lbier .

escservices commented 7 years ago

I have the same problem, images come through in Tv Shows and Music though.

tidusjar commented 7 years ago

Can someone change their admin password (so I can log in) and send me their database PlexRequests.sqlite or Ombi.sqlite to tidusjar@gmail.com ?

rulles commented 7 years ago

Hello.

The problem is in the format of email. If i see the raw data of email, in the section of image, have this:

and if i increase in the src of image this "https://image.tmdb.org/t/p/w150/", for exemple:

the image show just fine.

I think the problem is with the incomplete information on variable os something like this.

Atenciosamente/ With best Regards, António Pinto

2017-01-10 15:44 GMT+00:00 Jamie notifications@github.com:

Can someone change their admin password (so I can log in) and send me their database PlexRequests.sqlite or Ombi.sqlite to tidusjar@gmail.com ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271610065, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZpgKC_kOMOP0YG-rUSkfvQXqqNebks5rQ6dmgaJpZM4Lbier .

rulles commented 7 years ago

If you check this entry in database for example:

{"ProviderId":337339,"ImdbId":"tt4630562","TvDbId":null,"Overview":"Now that Dom and Letty are on their honeymoon and Brian and Mia have retired from the game and the rest of the crew has been exonerated-the globetrotting team has found a semblance of a normal life. But when a mysterious woman seduces Dom into the world of crime he can't seem to escape and a betrayal of those closest to him, they will face trials that will test them as never before. From the shores of Cuba and the streets of New York City to the icy plains off the arctic Barents Sea, the elite force will crisscross the globe to stop an anarchist from unleashing chaos on the world's stage... and to bring home the man who made them a family.","Title":"The Fate of the Furious","PosterPath":"/rRB6jtEMJ64lDDTINknIxU2z9V9.jpg","ReleaseDate":"2017-04-12T00:00:00","Type":0,"Status":"Post Production","Approved":true,"RequestedBy":null,"RequestedDate":"2016-12-19T15:35:09.891011Z","Available":false,"Issues":99,"OtherMessage":null,"AdminNote":null,"SeasonList":null,"SeasonCount":0,"SeasonsRequested":null,"MusicBrainzId":null,"RequestedUsers":["semlif"],"ArtistName":null,"ArtistId":null,"IssueId":0,"Episodes":[],"Denied":false,"DeniedReason":null,"Id":6}

The imformation of "PosterPath" is only the "/rRB6jtEMJ64lDDTINknIxU2z9V9.jpg" and i this that should be https://image.tmdb.org/t/p/w150//rRB6jtEMJ64lDDTINknIxU2z9V9.jpg

Atenciosamente/ With best Regards, António Pinto

2017-01-10 17:15 GMT+00:00 Antonio Pinto a.j.s.p.90@gmail.com:

Hello.

The problem is in the format of email. If i see the raw data of email, in the section of image, have this:

and if i increase in the src of image this "https://image.tmdb.org/t/p/ w150/", for exemple:

the image show just fine.

I think the problem is with the incomplete information on variable os something like this.

Atenciosamente/ With best Regards, António Pinto

2017-01-10 15:44 GMT+00:00 Jamie notifications@github.com:

Can someone change their admin password (so I can log in) and send me their database PlexRequests.sqlite or Ombi.sqlite to tidusjar@gmail.com ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271610065, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZpgKC_kOMOP0YG-rUSkfvQXqqNebks5rQ6dmgaJpZM4Lbier .

tidusjar commented 7 years ago

Hmmm, they seem to be returning something different now 😢

tidusjar commented 7 years ago

This has been fixed in the Early Access Preview branch.

rulles commented 7 years ago

Hello.

That is a good news. But nothing change in the database right?! I can use the same database right?!

Jamie notifications@github.com escreveu em qua, 11/01/2017 às 08:40 :

This has been fixed in the Early Access Preview branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271809982, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZjP4E1LYJY-MMvow0hX_xif4rmSCks5rRJWNgaJpZM4Lbier .

-- (Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

tidusjar commented 7 years ago

Correct!

rulles commented 7 years ago

Very nice!!!

Already try last version of EAP and work great.

Now, only miss the notifications of tv-shows when are requested and added.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 10:11 GMT+00:00 Jamie notifications@github.com:

Correct!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271829444, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZkI4yJV99JGE1ibXWeHmMi802Nbmks5rRKrKgaJpZM4Lbier .

rulles commented 7 years ago

I realised another thing about that image, i don't if is viable or not but i think it is much interesting if when the user click on the image of email notification go to IMDB page of that request.

Understand what i mean?

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:07 GMT+00:00 Antonio Pinto a.j.s.p.90@gmail.com:

Very nice!!!

Already try last version of EAP and work great.

Now, only miss the notifications of tv-shows when are requested and added.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 10:11 GMT+00:00 Jamie notifications@github.com:

Correct!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271829444, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZkI4yJV99JGE1ibXWeHmMi802Nbmks5rRKrKgaJpZM4Lbier .

tidusjar commented 7 years ago

You miss the notification? As in your never get it?

rulles commented 7 years ago

Yes, always have that problem.

Users do some tv-shows requests (full episodes) and the request appear in the requests tab, and when i add that tv-show in my plex-server, the user who did the request not receive the notification and in request tab don't show as available, but i search for that tv-show, that show as available.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:18 GMT+00:00 Jamie notifications@github.com:

You miss the notification? As in your never get it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271913442, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9Zrl5sdbrFeTlEE299g8NFlqTzcVpks5rRQDJgaJpZM4Lbier .

tidusjar commented 7 years ago

That's a different problem @rulles Can you raise a separate issue for that.

The issue originally reported has been fixed.

rulles commented 7 years ago

What problem do you mean? the hyperlink of image or the notifications of tv-shows?

If you mean the notifications of tv-shows, i already talk about this in other issue (Available shows not showing available in request page (#817)).

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:23 GMT+00:00 Jamie notifications@github.com:

That's a different problem @rulles https://github.com/rulles Can you raise a separate issue for that.

The issue originally reported has been fixed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271915098, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9Zs5Zhx5Oe39qjPvSZqjU3pbP-QlAks5rRQIHgaJpZM4Lbier .

tidusjar commented 7 years ago

Ah ok! Sorry mind went blank!

The hyperlink you can put that on Feathub: http://feathub.com/tidusjar/Ombi

rulles commented 7 years ago

But, in the other issue (Available shows not showing available in request page (#817)), no one give feedback.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:30 GMT+00:00 Jamie notifications@github.com:

Ah ok! Sorry mind went blank!

The hyperlink you can put that on Feathub: http://feathub.com/tidusjar/ Ombi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271917213, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZmEa47vQEDW4-vGf_9mo116xFtXvks5rRQOMgaJpZM4Lbier .

tidusjar commented 7 years ago

Because I'm still working on it :)

On Wed, 11 Jan 2017, 4:34 pm rulles, notifications@github.com wrote:

But, in the other issue (Available shows not showing available in request page (#817)), no one give feedback.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:30 GMT+00:00 Jamie notifications@github.com:

Ah ok! Sorry mind went blank!

The hyperlink you can put that on Feathub: http://feathub.com/tidusjar/ Ombi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271917213, or mute the thread < https://github.com/notifications/unsubscribe-auth/ANb9ZmEa47vQEDW4-vGf_9mo116xFtXvks5rRQOMgaJpZM4Lbier

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271918511, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVaLMoNRUBEw7vwlKMX3iByYNQc4k7yks5rRQSEgaJpZM4Lbier .

rulles commented 7 years ago

Oh, ok. Sorry for the insist.

I already have open another issue about custom email notification (Emails notifications triplicated (#835)) but without feedback about it. Only part of the issue is resolved. Do you know something about it?

Atenciosamente/ With best Regards, António Pinto

2017-01-11 17:23 GMT+00:00 Jamie notifications@github.com:

Because I'm still working on it :)

On Wed, 11 Jan 2017, 4:34 pm rulles, notifications@github.com wrote:

But, in the other issue (Available shows not showing available in request page (#817)), no one give feedback.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:30 GMT+00:00 Jamie notifications@github.com:

Ah ok! Sorry mind went blank!

The hyperlink you can put that on Feathub: http://feathub.com/tidusjar/ Ombi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271917213, or mute the thread < https://github.com/notifications/unsubscribe-auth/ANb9ZmEa47vQEDW4-vGf_ 9mo116xFtXvks5rRQOMgaJpZM4Lbier

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271918511, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGVaLMoNRUBEw7vwlKMX3iByYNQc4k7yks5rRQSEgaJpZM4Lbier .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271932660, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZugUkMWd16qgXxsWz9F0OAUAV-nQks5rRRABgaJpZM4Lbier .

rulles commented 7 years ago

Hello, i have a problem, today i do the last update of EAP branch and now my admin acount cannot see the requests of other users.

Can you tell me where i can do the download of the previous version of the EAP?

Atenciosamente/ With best Regards, António Pinto

2017-01-11 17:29 GMT+00:00 Antonio Pinto a.j.s.p.90@gmail.com:

Oh, ok. Sorry for the insist.

I already have open another issue about custom email notification (Emails notifications triplicated (#835)) but without feedback about it. Only part of the issue is resolved. Do you know something about it?

Atenciosamente/ With best Regards, António Pinto

2017-01-11 17:23 GMT+00:00 Jamie notifications@github.com:

Because I'm still working on it :)

On Wed, 11 Jan 2017, 4:34 pm rulles, notifications@github.com wrote:

But, in the other issue (Available shows not showing available in request page (#817)), no one give feedback.

Atenciosamente/ With best Regards, António Pinto

2017-01-11 16:30 GMT+00:00 Jamie notifications@github.com:

Ah ok! Sorry mind went blank!

The hyperlink you can put that on Feathub: http://feathub.com/tidusjar/ Ombi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271917213, or mute the thread < https://github.com/notifications/unsubscribe-auth/ ANb9ZmEa47vQEDW4-vGf_9mo116xFtXvks5rRQOMgaJpZM4Lbier

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271918511, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVaLMoNR UBEw7vwlKMX3iByYNQc4k7yks5rRQSEgaJpZM4Lbier .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-271932660, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9ZugUkMWd16qgXxsWz9F0OAUAV-nQks5rRRABgaJpZM4Lbier .

tidusjar commented 7 years ago

@rulles Check your filter.

rulles commented 7 years ago

What filter?!

Jamie notifications@github.com escreveu em qui, 12/01/2017 às 14:16 :

@rulles https://github.com/rulles Check your filter.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tidusjar/Ombi/issues/891#issuecomment-272173616, or mute the thread https://github.com/notifications/unsubscribe-auth/ANb9Zkv4_rBhgAaf9GFhgpfeP_-BDNhjks5rRjWzgaJpZM4Lbier .

-- (Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

tidusjar commented 7 years ago

In the UI. There is a filter and sort