OmegaHawkeye / kirimase

Build full-stack Next.js apps, incredibly fast
https://kirimase.dev
MIT License
7 stars 1 forks source link

kirimase is getting messy | add templating engine #38

Open OmegaHawkeye opened 6 months ago

OmegaHawkeye commented 6 months ago

From kirimase created by ahmedrowaihi: nicoalbanese/kirimase#102

first of all, I AM SO THANKFUL TO YOU GUYS, I really love the effort and energy has been done here, and I would love to contribute to this project when I finish my final exams

I noticed that the boilerplates are becoming hard to track and maintain, so

Problem : the generators files are getting big and complex

solution

use an amazing templating engine
we can separate implementations for different options by keeping each on its own directory with handlebarsjs

example:

this way we can keep the boilerplate easy to plug-play and also easy to debug and spot bugs

OmegaHawkeye commented 6 months ago

@nicoalbanese if this seems like a worthwhile enhancement to focus on, would you be open to me turning this into an epic and then making small PRs that chip away at this work? On this issue, we can start to compile a checklist of which templates are outstanding. Thanks for all the work on this!

Update: given some of the rails inspiration for kirimase, I wonder whether you'd be open to using eta, which has an ERB style syntax and supports partials?

afogel commented 6 months ago

@OmegaHawkeye lemme know if you'd like me to try to push the eta change against this repo. Happy to move this project forward some.

OmegaHawkeye commented 6 months ago

Gladly but I already implemented your changes for the Data table. I'll tag u in the changelog then.

Currently trying to figure out if I should only convert the most important React Components to templates or everything but the most basic functions.

Should I start a discussion on this?

I'll also push the current changes today or tomorrow into the feature or main branch.

afogel commented 6 months ago

🙏 awesome; yeah, seems like a good subject for a discussion. I'll branch off of your main and we can continue building on this.