OmegaK2 / PyPoE

Collection of Python Tools for Path of Exile
Other
237 stars 92 forks source link

added in the four missing index handlers #149

Closed NickRyder closed 3 years ago

NickRyder commented 3 years ago

This adds in the four missing index handlers that were triggering UnknownIdentifierWarning

One caveat here - the passive_hash handlers I believe break the paradigm of the values being fed into the handler being from the stat ranges on the mods, since the passive_hash comes from Allocates ___ on amulet/ring enchants, and these values are all ranged min = 0, max = 0. From what I can tell, the value used to create the string here comes from an attribute on the item called notableProperties.

Not sure if there are other examples of this in PyPoE I should be following, or if this behavior is unique to passive_hash

markliu06 commented 3 years ago

@L1mer

Data/IndexableSupportGems.dat

Seem so. Using new merged code and manually pull some file from @brather1ng's fork for 3.14 spec does not work. Fix this line of code

    handler=lambda v: relational_reader['IndexableSupports.dat'][v]['Name'],

at least bypass the following error:

FileNotFoundError: [Errno 2] No such file or directory: