OmegaK2 / PyPoE

Collection of Python Tools for Path of Exile
Other
240 stars 93 forks source link

Essences.dat spec overhaul #54

Closed eps1lon closed 6 years ago

eps1lon commented 6 years ago

Basically all mod keys fall into two groups:

Only quivers have one field for display and application.

The display fields relate to certain groups e.g. Ranged Weapon or One Hand Weapon. There is some additional squash logic applied e.g. if Weapon and Item have the same mod key only Item is displayed because Weapon inherits from Item. Additionally if Weapon would have a different mod key the Item line would be prefixed with Other. Don't use the Wiki as a reference here because some essences (e.g. Contempt) are not displayed as they are shown ingame. In the case of Contempt essences the wiki shows Shield and Other Armour mods despite them having the same stats and only Other Armor shown ingame.

Currently the following lines are squashed:

There might be a single inheritance chain to it but for now this list is sufficient enough to mirror ingame display.

The field names for applied mods regarding 1H and 2H weapons are guessed because there exists currently no essence that applies different mods to maces or axes. I just went with the order in which they appear in ItemClasses.dat.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 42.202% when pulling a7d6e4ed10843903a74298a733ff628dc58fbee1 on eps1lon:fix-spec-essence into 2798badf734f88ea520e4901915c5d2527a74479 on OmegaK2:dev.