search

OmegaPhil / animecheck

Commandline CRC32, MD5 and eD2k-based hashing script also capable of reading and creating SFV and MD5 checksum files and generating eD2k links. This is an initial foray into python and github
GNU General Public License v3.0
46 stars 5 forks source link

Fix issues in Windows and Python 3 #3

Closed wiiaboo closed 12 years ago

wiiaboo commented 12 years ago

Only tested --add-hash-mode.

Thanks for the modifications to tiaoufix's animecheck.py. Been using his script for years and only found out about yours today.

wiiaboo commented 12 years ago

I think I managed to test every mode now in both Python 2.7 and 3.2, so it should be safe to pull it.

OmegaPhil commented 12 years ago

Wow, my first pull request ;)

Unfortunately my main machine is dead again for the second time in half a year, so it will be a long time before I can reach this. But reach this I will.

OmegaPhil commented 12 years ago

I have started to look at this now. Because I dont agree with every commit, I am going to pull this down locally, do some cherry picking etc. Presumably merging and then changing the things I don't like is bad form? But that seems to be all I can do from this interface.

wiiaboo commented 12 years ago

I don't really care about "bad form". The code is yours to do whatever you want, after all. I basically just did some bug fixes, so there's nothing to be anal about wanting to get recognised.

If there's any code you'd rather not integrate, that's up to you.

OmegaPhil commented 12 years ago

OK. Interactive rebasing has worked, will be able to continue on this today.

OmegaPhil commented 12 years ago

Thank you for your pull request :) I have now released v0.5, however this is different from your v0.5.

I did not keep the following commits:

Exceptions don't need to be implicitely imported: Needed for Pydev intellisense. Change --add-hash-mode to boolean variable: Removes functionality I use.