search

OmegaPhil / animecheck

Commandline CRC32, MD5 and eD2k-based hashing script also capable of reading and creating SFV and MD5 checksum files and generating eD2k links. This is an initial foray into python and github
GNU General Public License v3.0
46 stars 5 forks source link

Misleading checksum file completion message after errors, checksum file leaves no indication of issues #6

Closed OmegaPhil closed 12 years ago

OmegaPhil commented 12 years ago

Even after errors during file hashing for checksum file creation (e.g. '[Errno 5] Input/output error'), the following is still reported at the end:

Checksum file '' has been written successfully

It was probably a throughaway line to indicate the writing of the checksum file to disc worked, but it gives the wrong impression of the job as a whole.

Worse than this, the failed files leave no record in the checksum file, and therefore if the user uses the subsequent file after not paying attention to the original generation, they may be led to believe the dataset is not corrupt.

OmegaPhil commented 12 years ago

Fixed in #e5989e8bf8aa0830a0084025232b77c80a7bdf0c