OmerTu / GoogleHomeKodi

Control kodi via Google Home / Assistant
523 stars 163 forks source link

Multiple movies #70

Open srmysqldba opened 6 years ago

srmysqldba commented 6 years ago

This is workimg great. I setup up a docker image running on a raspberry pi. No issues getting mutiple rooms working. However there is a small bug, or maybe I'm speakimg wrong. Issue 1: 6 Scooby Doo Movies If i say " Ok Google Kodi play Scooby do and the witches ghost in the kids room" If plays the first Scooby Doo movie If I say "Ok Google Kodi play the witches ghost in the kids room" That works

Issue 2: I have all 3 Men in Blacks Men in Black Men in Black Ii Men in Black 3 If I say "Ok Google kodi play Mein in Black 2 in the Living room" It plays Men in Black 3

I looked at logs and it has the right movie titles but wrong ID.

keydon commented 6 years ago

define "right movie title". did google recognize exactly "men in black II" like saved in your library, or did it recognize "men in black 2". i guess the later. thats difficult to solve, but i guess we could do some normalization against the title in the movie library and against the title requested by the user. like II -> two and 2 -> two etc. mhhh

srmysqldba commented 6 years ago

Im testing a new load and renamed the move from II to 2 and updated movie.nfo and will ensure its updated in the shared DB. Ill let you know my findings.

disrupted commented 6 years ago

@srmysqldba sorry for hijacking this thread but I see you mentioned you're using this in a Docker container. Would you mind sharing your Dockerfile to create the image? I'd like to set this up locally as well.

srmysqldba commented 6 years ago

sharing your Dockerfile to create the image Sure @disrupted This is a very basic Dockerfile


FROM node:carbon

Create app directory

WORKDIR /usr/src/app

Install app dependencies

A wildcard is used to ensure both package.json AND package-lock.json are copied

where available (npm@5+)

COPY package*.json ./

RUN npm install

If you are building your code for production

RUN npm install --only=production

Bundle app source

COPY . .

EXPOSE 8080 CMD [ "npm", "start" ]

srmysqldba commented 6 years ago

Also, I had no luck with renaming, However I if I say "II" instead of 2 It plays the correct movie. This is not a huge issue and I am really loving this. I am working on testing with Dialoggflow to build an interactive form and will also allow the user to pass more than 1 variable. If it works I will post details.