search

OmgDef / yii2-multilingual-behavior

Yii2 port of the yii-multilingual-behavior.
146 stars 60 forks source link

Made yii2-multilingual-behavior more extensible. #48

Closed ddinchev closed 8 years ago

ddinchev commented 8 years ago

The $langClassSuffix property is now configurable (I use the ML suffix for historical reasons - same as my table suffix).

Also I wanted to set the $currentLanguage property from a subclass and noticed it was private. This actually was by mistake - I see there is a check if (!$this->currentLanguage) but if the property is private, that would never evaluate to false. So I changed it to public instead.

OmgDef commented 8 years ago

@ddinchev I'll merge your pull request when you repair the tests

ddinchev commented 8 years ago

Ah, yes, sorry - I didn't run the tests and hadn't commit the whole thing properly. I've fixed my commit.

OmgDef commented 8 years ago

@ddinchev thanks!

ddinchev commented 8 years ago

@OmgDef given that you merged this into master - could you bump the version (e.g. 2.1.2) so that composer picks up the update?

OmgDef commented 8 years ago

@ddinchev done

ddinchev commented 8 years ago

@OmgDef thank you!